-
-
Notifications
You must be signed in to change notification settings - Fork 103
feat: add dexId (Pokédex ID) to cards #1011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🃏 2041 Cards ChangedDetails: 2041 modified, 42 without images Rocket’s Scizor (bog-4) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/4.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/4.ts) Rocket’s Sneasel (bog-5) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/5.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/5.ts) Dark Ivysaur (bog-6) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/6.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/6.ts) Dark Venusaur (bog-7) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/7.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/7.ts) Rocket’s Mewtwo (bog-8) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/8.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/8.ts) Rocket’s Hitmonchan (bog-9) (found using en) (no images)No images available for this card File: [data/E-Card/Best of game/9.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/E-Card/Best of game/9.ts) Buried Fossil (ecard3-47) (found using en)File: data/E-Card/Skyridge/47.ts Darkrai & Cresselia LEGEND (hgss4-100) (found using en)File: [data/HeartGold & SoulSilver/Triumphant/100.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Triumphant/100.ts) Palkia & Dialga LEGEND (hgss4-101) (found using en)File: [data/HeartGold & SoulSilver/Triumphant/101.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Triumphant/101.ts) Palkia & Dialga LEGEND (hgss4-102) (found using en)File: [data/HeartGold & SoulSilver/Triumphant/102.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Triumphant/102.ts) Darkrai & Cresselia LEGEND (hgss4-99) (found using en)File: [data/HeartGold & SoulSilver/Triumphant/99.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Triumphant/99.ts) Kyogre & Groudon LEGEND (hgss3-87) (found using en)File: [data/HeartGold & SoulSilver/Undaunted/87.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Undaunted/87.ts) Kyogre & Groudon LEGEND (hgss3-88) (found using en)File: [data/HeartGold & SoulSilver/Undaunted/88.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Undaunted/88.ts) Rayquaza & Deoxys LEGEND (hgss3-89) (found using en)File: [data/HeartGold & SoulSilver/Undaunted/89.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Undaunted/89.ts) Rayquaza & Deoxys LEGEND (hgss3-90) (found using en)File: [data/HeartGold & SoulSilver/Undaunted/90.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Undaunted/90.ts) Entei & Raikou LEGEND (hgss2-90) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/90.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/90.ts) Entei & Raikou LEGEND (hgss2-91) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/91.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/91.ts) Raikou & Suicune LEGEND (hgss2-92) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/92.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/92.ts) Raikou & Suicune LEGEND (hgss2-93) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/93.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/93.ts) Suicune & Entei LEGEND (hgss2-94) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/94.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/94.ts) Suicune & Entei LEGEND (hgss2-95) (found using en)File: [data/HeartGold & SoulSilver/Unleashed/95.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/HeartGold & SoulSilver/Unleashed/95.ts) Oddish (me02-001) (found using en)File: [data/Mega Evolution/Phantasmal Flames/001.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/001.ts) Gloom (me02-002) (found using en)File: [data/Mega Evolution/Phantasmal Flames/002.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/002.ts) Vileplume (me02-003) (found using en)File: [data/Mega Evolution/Phantasmal Flames/003.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/003.ts) Mega Heracross ex (me02-004) (found using en)File: [data/Mega Evolution/Phantasmal Flames/004.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/004.ts) Lotad (me02-005) (found using en)File: [data/Mega Evolution/Phantasmal Flames/005.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/005.ts) Lombre (me02-006) (found using en)File: [data/Mega Evolution/Phantasmal Flames/006.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/006.ts) Ludicolo (me02-007) (found using en)File: [data/Mega Evolution/Phantasmal Flames/007.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/007.ts) Genesect (me02-008) (found using en)File: [data/Mega Evolution/Phantasmal Flames/008.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/008.ts) Nymble (me02-009) (found using en)File: [data/Mega Evolution/Phantasmal Flames/009.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/009.ts) Lokix (me02-010) (found using en)File: [data/Mega Evolution/Phantasmal Flames/010.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/010.ts) Charmander (me02-011) (found using en)File: [data/Mega Evolution/Phantasmal Flames/011.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/011.ts) Charmeleon (me02-012) (found using en)File: [data/Mega Evolution/Phantasmal Flames/012.ts](https://github.com/tcgdex/cards-database/blob/ba4462be222a835ced60324bb55a263d6224a980/data/Mega Evolution/Phantasmal Flames/012.ts)
|
|
Hi, |
acc9032 to
8380f24
Compare
|
fixed redundant poked ID and hardened the test iml |
|
A few observations. You added a few files that are not relevant to your feature:
|
- Add dexId (Pokédex ID) to Pokémon cards across multiple sets - Fix duplicate dexId properties in Mega Evolution/Phantasmal Flames - Fix duplicate dexId in Scarlet & Violet/SVP Black Star Promos - Update CI workflow to wait for server readiness before running tests
a2ed0e5 to
6189168
Compare
- Add audit, fix, lint, and mapping generation tools - Add npm scripts for dex:audit, dex:fix, dex:lint - Update import paths to use ../utils/
- Fix data directory paths (../../data instead of ../data) - Make README more contributor-friendly with tables and workflow guide
- Add Terapagos (1024) and Terapagos & Friends multi-Pokemon mapping - Add all Paldea starters: Sprigatito/Floragato/Meowscarada (906-908), Fuecoco/Crocalor/Skeledirge (909-911), Quaxly/Quaxwell/Quaquaval (912-914) - Fix typo in SVP Black Star Promos/500.ts: 9012 -> 912 (Quaxly)
|
Thanks for the thorough review! I’ve tightened the PR to focus strictly on the dexId feature set and addressed all requested updates: |




































































































































































































































































































































Changes
Add Pokédex IDs to cards in:
Details
Include workdir/ with tools for future dexId maintenance: