Skip to content

Web add invite external flow#43

Open
MarcWadai wants to merge 4 commits into
mainfrom
web-add-invite-external-flow
Open

Web add invite external flow#43
MarcWadai wants to merge 4 commits into
mainfrom
web-add-invite-external-flow

Conversation

@MarcWadai
Copy link
Copy Markdown
Contributor

No description provided.

@MarcWadai MarcWadai requested a review from odelcroi April 29, 2026 14:52
Comment thread playwright.config.ts

// Load environment variables from the appropriate .env file
dotenv.config({ path: path.resolve(__dirname, `.env.${env}`) });

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move initialization of dotenv config on one place only (at the higher call)

@MarcWadai MarcWadai force-pushed the web-add-invite-external-flow branch from 4c6059a to 2c5c684 Compare April 29, 2026 14:53

// Helper function to create a public room
async function createPublicRoom(page: Page, roomName: string): Promise<string> {
export async function createPublicRoom(page: Page, roomName: string): Promise<string> {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expose the room creation fonction, since it will be used in lot of places

Comment thread fixtures/auth-fixture.ts
await deactivateMasUser(userId);
console.log(`Cleaned up MAS user: ${user.username}`);
// await deactivateMasUser(userId);
// console.log(`Cleaned up MAS user: ${user.username}`);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO : clean up the users only after the tests finish running. Will be good to delete also room creation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants