Fix bundled DCCCcore launch from the UI - #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DCCCcoreon Linux/macOS andDCCCcore.exeon Windows4.2.5Root cause
The native executable was renamed from
CentiloidCalculatortoDCCCcorein v4.0, but the Slicer UI continued to launch the legacy filename. Release packages contain onlyDCCCcore, so the process failed before calculation started.Impact
This restores PET metric and AI decoupling launches from packaged DCCCSlicer releases. Tagged 4.x releases from
v4.0.0-alphathroughv4.2.4are affected.Validation
uvx --from pytest pytest -q localizer/src/tests/test_ui_metric_command_builder.py— 6 passedgit diff --checkFixes #37