fix: browser pipe not added when running dashboard standalone - #6
Merged
Merged
Conversation
Router now composes `phx.install.core` and dashboard composes `phx.install.endpoint` and `phx.install.live` so that running these tasks standalone sets up the application module and supervision tree. Closes #4
Fix `find_dev_routes_block` to match the actual Sourceror AST for
`Application.compile_env(...)` — the old pattern matched a bare
`:compile_env` atom call but the real AST uses a dot-call form
(`{{:., _, [{:__aliases__, _, [:Application]}, :compile_env]}, _, args}`).
When an existing dev_routes block is found without `live_dashboard`,
navigate into the scope "/dev" and insert the route + import rather
than emitting a warning or creating a duplicate block.
jimsynz
force-pushed
the
fix/compose-core-in-subtasks
branch
from
March 23, 2026 03:08
55446e0 to
332b1cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3
find_dev_routes_blockAST pattern matching — the old pattern matched a bare:compile_envatom but Sourceror's AST forApplication.compile_env(...)uses a dot-call form, so the function never matched any existing dev_routes blockslive_dashboard, navigate into thescope "/dev"and insert the route + import rather than emitting a warning or creating a duplicate blockroutercomposescore,dashboardcomposesendpoint+live) so standalone invocation works correctlyTest plan
phx.install.dashboardinvocation composes prerequisites and adds:browserpipelinelive_dashboardis inserted into an existingdev_routesblock without duplication