Repository navigation
[FEAT/#122] AsyncImage로 변경 - #125
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
ChangesUrlImage 로딩 처리
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: ⚪ Minimal · up to No actionable issue is established that should block merging. The reported loading placeholder remains a design follow-up. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
p1: 아무래도 이미지가 있어야하니까.. 이거 필수 파라미터로 옮겨야 할 듯,,ㅎㅎ
Related issue 🛠
Work Description ✏️
UrlImage의SubcomposeAsyncImage→AsyncImage교체isLoading) 처리Uncompleted Tasks 😅
To Reviewers 📢
gray50배경으로 처리했습니다. 해당 위치에TODO주석을 남겨 두었고, 디자인이 정해지면 그 분기만 수정하면 됩니다.modifier가 바깥과 안쪽에 두 번 적용되던 구조가 한 번만 적용되도록 바뀌었습니다. padding이 들어간 호출부는 실패 시 레이아웃이 기존과 조금 다를 수 있습니다.Summary by CodeRabbit