test: preserve user changes across failed pull retries - #1218
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 2 remain after this review. WalkthroughThe change adds two regression tests for merge retries after failed checkouts. The tests cover edited conflict copies and deleted files, then verify preserved first-parent state, remote merge content, clean repository state, and resolved index conflicts. ChangesMerge retry regressions
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This adds regression coverage for preserving edited conflict copies and deleted notes across failed pull retries, with no production behavior changes or current merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
Adds two failure/retry regressions to #1215, following the remaining review cases from #1209:
This is intentionally based on
codex/git-sync-reliabilityso the diff contains only the added tests. It can be merged into #1215 or cherry-picked; it does not ask to merge the old recovery mechanism from #1209. The in-memory merge in #1215 avoids creating theMERGE_*state that mechanism would recover.Validation passed:
cargo test -p reflect-open git::merge_tests(11 tests, including both additions),cargo fmt --all --check,cargo clippy -p reflect-open --all-targets -- -D warnings,pnpm check, andpnpm build. These tests exercise deterministic checkout failure and retry; they do not claim physical-device kill testing or migration of pre-existing foreign Git merges.Summary by CodeRabbit