Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Author
|
implemented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
X post captures currently go through generic page metadata, and bookmark/like actions are not captured. This adds manual post snapshots and opt-in automatic capture through the existing extension queue and native inbox.
Manual saves create independent notes with their own annotation, selection and screenshot. Automatic bookmark/like captures keep the first snapshot for each post and capture day. Repeated deliveries finish the original save without rewriting completed notes or merging annotations.
docs/plans/25-x-capture.md, update privacy disclosures, and cover replay, ownership, transport compatibility and DOM behavior.Validation:
pnpm check, desktop Vite build and extension WXT production build passed. Targeted tests passed: 218 core/extension tests, 3 Chromium DOM tests and 23 native-host tests. Four temporary mutations each failed the intended behavior assertion: replacing no-clobber creation, removing ownership/privacy gates, swallowing asset-write errors, and reversing complete-text preference. Source was restored and the targeted suite passed again.The built X script is 9.39 kB and contains the DOM adapter, capture builder and WXT lifecycle runtime, without Zod or Defuddle. The generated manifest adds optional X/Twitter host permissions and no permanent host permissions. Final CI passed on
744f7e7b: lint/typecheck/build, all six Chromium/WebKit shards, Rust fmt/clippy/tests, Apple desktop/iOS bindings, autofix and the all-green gate. CodeRabbit skips automatic review while the PR is a draft.Draft acceptance remains: authenticated X mouse/keyboard actions, long-post expansion and multiple views, plus permission removal and extension updates with already-open tabs. Public logged-out article/ARIA markup was inspected, but reduced DOM fixtures do not prove these authenticated browser behaviors. The existing 50-item queue limit and filesystem read/check/write concurrency boundary are documented in Plan 25.