Conversation
Fix resetting `isHandleRequested` in `OPFSCoopSyncVFS`
Bump package version.
Fix hello demo import paths.
…shimoto#272) * Permit boolean values to be bound to statements, as 0/1 * Add test for boolean binding
…stance Use a single `TextEncoder` instance
Export HEAP* module members for recent EMSDK changes.
Bumps [tar-fs](https://github.com/mafintosh/tar-fs) from 3.0.8 to 3.0.9. - [Commits](mafintosh/tar-fs@v3.0.8...v3.0.9) --- updated-dependencies: - dependency-name: tar-fs dependency-version: 3.0.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…yarn/tar-fs-3.0.9 Bump tar-fs from 3.0.8 to 3.0.9
Update SQLite to 3.50.1.
Bump package version.
* Replace Proxy with handwritten proxy for jRead/jWrite buffers. * Replace Proxy with handwritten proxy for VFS return data. --------- Co-authored-by: Roy Hashimoto <roy@shoestringresearch.com>
* Use non-CAPTCHA SQLite download URL. * Use consistent Makefile variable bracing. --------- Co-authored-by: Roy Hashimoto <roy@shoestringresearch.com>
* Fix WebLocksMixin state initialization. * Don't fetch state in WebLocksMixin file control unnecessarily. * Minor fixes. --------- Co-authored-by: Roy Hashimoto <roy@shoestringresearch.com>
WalkthroughThis change updates dependencies and build metadata, adjusts demo import paths, adds runtime heap exports, replaces internal memory/view wrappers in FacadeVFS, refactors lock-state retrieval in WebLocksMixin, tweaks VFS behaviors, adds boolean binding in sqlite-api with tests, and updates global heap typings. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant App as Application
participant API as sqlite-api.js
participant C as SQLite C/WASM
rect rgb(245,248,255)
note over App,API: Prepare & bind (new: boolean support)
App->>API: sqlite3.prepare(sql)
App->>API: sqlite3.bind(param, true/false)
alt value is boolean (new)
API->>C: bind_int(param, 1 or 0)
C-->>API: SQLITE_OK
else other types
API->>C: bind_* accordingly
C-->>API: SQLITE_OK/ERR
end
end
App->>API: sqlite3.step()
API->>C: sqlite3_step
C-->>API: row/done
API-->>App: result
sequenceDiagram
autonumber
participant VFS as FacadeVFS
participant Mem as WASM Memory
participant View as DataViewProxy/Uint8ArrayProxy
note over VFS,View: Accessing memory-backed data (changed: rebind-on-resize)
VFS->>View: get view at offset/length
View->>Mem: ensure buffer is current (rebind if detached)
Mem-->>View: current buffer
View-->>VFS: read/write via getters/setters
alt Memory grows
Mem-->>View: old buffer detached
VFS->>View: subsequent access
View->>Mem: reacquire new buffer
Mem-->>View: new buffer
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (9)
.github/ISSUE_TEMPLATE/-do-not-post-anything-other-than-a-bug-report.md (4)
2-2: Remove leading space in template name.The leading space before "Do" will render oddly in the template picker.
-name: " Do not post anything other than a bug report" +name: "Do not post anything other than a bug report"
4-6: Drop empty front‑matter keys instead of setting empty strings.Empty strings for title/labels/assignees can behave unexpectedly; omitting them is cleaner.
-title: '' -labels: '' -assignees: ''
8-10: Add a minimal body to guide reporters.Without content, users won’t see any instructions. Add a short section with required info.
--- - +Please use this template only for reproducible bugs in the project code. + +Provide: +- Version (commit or release) +- Environment (browser/runtime) +- Steps to reproduce +- Expected vs. actual behavior +- Relevant logs or errors
1-1: Optional: Consider renaming file to avoid leading hyphen.The leading “-” only affects sort order; if unintentional, rename to do-not-post-anything-other-than-a-bug-report.md.
src/FacadeVFS.js (3)
416-418: Fix JSDoc return type to match implementation (DataViewProxy).
Prevents confusion and aids tooling.- * @returns {DataView} + * @returns {DataViewProxy}
429-432: Fix JSDoc return type or clarify contract.
This returns a Uint8Array-like proxy, not a real Uint8Array. Clarify to reduce misuse.- * @returns {Uint8Array} + * @returns {Uint8Array} (Uint8Array-like proxy; use .subarray() for a real Uint8Array)
486-613: Match TypedArray mutator return values for chainability.
copyWithin/fill/reverse/sort should return the array to mirror Uint8Array semantics and avoid surprising callers.copyWithin(target, start, end) { - this.#array.copyWithin(target, start, end); + return this.#array.copyWithin(target, start, end); } @@ fill(value, start, end) { - this.#array.fill(value, start, end); + return this.#array.fill(value, start, end); } @@ reverse() { - this.#array.reverse(); + return this.#array.reverse(); } @@ sort(compareFn) { - this.#array.sort(compareFn); + return this.#array.sort(compareFn); }src/sqlite-api.js (1)
521-546: Add parallel boolean support in sqlite3.result for consistency.
Results from custom functions should mirror bind semantics.sqlite3.result = function(context, value) { switch (typeof value) { case 'number': @@ case 'string': sqlite3.result_text(context, value); break; + case 'boolean': + sqlite3.result_int(context, value ? 1 : 0); + break; default:test/api_statements.js (1)
241-260: Good coverage: boolean bind as integer.
Consider adding a false case to assert 0 as well.it('should bind boolean', async function() { @@ - const storeValue = true; - const expectedRetrievedValue = 1; + const storeValue = true; + const expectedRetrievedValue = 1; @@ }); + + it('should bind boolean false', async function() { + let rc; + const sql = 'SELECT ?'; + for await (const stmt of i(sqlite3.statements(db, sql))) { + rc = await sqlite3.bind$(stmt, 1, false); + expect(rc).toEqual(SQLite.SQLITE_OK); + while ((rc = await sqlite3.step(stmt)) !== SQLite.SQLITE_DONE) { + expect(rc).toEqual(SQLite.SQLITE_ROW); + expect(await sqlite3.column_type(stmt, 0)).toEqual(SQLite.SQLITE_INTEGER); + expect(await sqlite3.column_int(stmt, 0)).toEqual(0); + } + } + });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
dist/wa-sqlite-async.wasmis excluded by!**/dist/**,!**/*.wasmdist/wa-sqlite-jspi.wasmis excluded by!**/dist/**,!**/*.wasmdist/wa-sqlite.wasmis excluded by!**/dist/**,!**/*.wasmyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (12)
.github/ISSUE_TEMPLATE/-do-not-post-anything-other-than-a-bug-report.md(1 hunks)Makefile(1 hunks)demo/hello/hello.js(2 hunks)package.json(1 hunks)src/FacadeVFS.js(2 hunks)src/WebLocksMixin.js(4 hunks)src/examples/MemoryVFS.js(1 hunks)src/examples/OPFSCoopSyncVFS.js(1 hunks)src/extra_exported_runtime_methods.json(1 hunks)src/sqlite-api.js(3 hunks)src/types/globals.d.ts(1 hunks)test/api_statements.js(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (3)
src/examples/MemoryVFS.js (2)
test/vfs_xRead.js (2)
iOffset(26-26)pData(25-25)test/vfs_xWrite.js (2)
iOffset(26-26)pData(25-25)
test/api_statements.js (1)
src/sqlite-api.js (7)
rc(492-492)rc(700-708)rc(735-735)i(101-101)i(363-363)i(609-609)sqlite3(28-28)
src/FacadeVFS.js (1)
src/examples/OPFSPermutedVFS.js (1)
array(1204-1207)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build (20.x)
🔇 Additional comments (12)
.github/ISSUE_TEMPLATE/-do-not-post-anything-other-than-a-bug-report.md (1)
1-11: No stray “11” at EOF
Verified absence of a standalone “11” in the file.src/examples/OPFSCoopSyncVFS.js (1)
437-441: Good alignment of request state with the shared persistent file.Clearing
isHandleRequestedon the sharedPersistentFileobject keeps the state consistent across connections and matches where the flag is now set. Looks great.src/WebLocksMixin.js (1)
128-141: Nice encapsulation of lock-state initialization.Centralizing the lazy creation logic in
#getLockState()removes repetition and keeps the downstream call sites cleaner while preserving the existing defaults. 👍demo/hello/hello.js (2)
7-9: Approve import path bump. All referenced files in dist/ (wa-sqlite.mjs, wa-sqlite-async.mjs, wa-sqlite-jspi.mjs) are present.
22-26: Approve VFS example import paths — All referenced files exist under src/examples.package.json (1)
3-3: Version bump to 1.0.9 looks good.
Matches the upstream sync scope; no concerns.src/examples/MemoryVFS.js (1)
119-119: Good: ensure a real Uint8Array source in set().
Using pData.subarray() avoids proxy pitfalls and keeps copying semantics predictable during WASM memory resizes.src/extra_exported_runtime_methods.json (1)
13-15: Exporting HEAP32/HEAPU8 is appropriate.
Aligns with updated typings and runtime access patterns.src/sqlite-api.js (2)
37-37: Good: shared TextEncoder reuse.
Reduces allocations on hot paths; consistent use across helpers looks good.Also applies to: 42-42, 665-665
122-124: Nice: boolean binding support.
Mapping booleans to integers aligns with SQLite typing.src/types/globals.d.ts (1)
14-14: HEAP32 addition is fine; HEAPU32 is still referenced in generated bundles — verify consumers.
rg found HEAPU32 only in generated files: dist/wa-sqlite.mjs, dist/wa-sqlite-async.mjs, dist/wa-sqlite-jspi.mjs — if these are build artifacts, either regenerate builds to match the types change or ensure downstream code expecting HEAPU32 remains compatible.Makefile (1)
2-3: SQLite tarball URL and contents verified
HTTP 200 response;configurefound atsqlite/configureandsqlite/autoconf/tea/configure.
4 participants
Summary by CodeRabbit