fix(Net/persist): 纠正错误处理方式，拿掉 err 是 Observable 的假设#663
Open
fix(Net/persist): 纠正错误处理方式，拿掉 err 是 Observable 的假设#663
Conversation
...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable 的情况；这不符合正常操作习惯。
Contributor
Author
|
@2eha0 这个修正我还没处理完，等上面两个 todo 里的东西处理好了，我找你帮忙 review 一下哈，谢谢 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...err 是 Observable 的合理可能只存在于有地方抛错时抛的是 Observable
的情况；这不符合正常操作习惯。（已经在 #668 中由于导致测试失败提前调整）