fix(warp): attach CONNECT proxy to main server and reuse running instance - #251
Open
garrettg123 wants to merge 1 commit into
Open
fix(warp): attach CONNECT proxy to main server and reuse running instance#251garrettg123 wants to merge 1 commit into
garrettg123 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables the
CONNECTforward proxy and absolute-form HTTP handlers directly on pxpipe-proxy's main server (default port 47821) and updatespxpipe warpto reuse an already-running pxpipe instance on127.0.0.1:<port>when available.Problem
pxpipe warpspawns a temporary CONNECT proxy on an ephemeral port (port 0).HTTP_PROXY=http://127.0.0.1:<ephemeral_port>.warpprocess exits, the ephemeral port stops listening. The long-running daemon and its spawned background workers remain pointing at the dead port, leading toECONNREFUSED/ "Connection refused — a firewall or proxy may be blocking it" on subsequent prompts.Fix
handlers.handleConnect(server.on('connect', ...)) andhandlers.handleAbsoluteFormto the maincreateServerinsrc/node.ts.createWarpRuntime(src/warp/index.ts), probe127.0.0.1:${port}before starting an ephemeral listener; if the proxy is already running on that port, reuse it directly.tests/warp-connect.test.ts) validating HTTPS CONNECT proxy tunneling and local route diversion.