Skip to content

#104: close current browser popup instead of last browser popup #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amuehlhause wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#104: close current browser popup instead of last browser popup #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/kylo/chrome/polo/content/browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,15 @@ Browser.prototype.getZoomLevel = function() {
return this.getMarkupDocumentViewer().fullZoom;
}

/**
* Returns index of browser
* @name getBrowserIndex
* @returns {Number} The current index of browser
*/
Browser.prototype.getBrowserIndex = function () {
return this.browserIndex_;
}

/**
* Sets the zoom level for the current browser and updates
* the zoom widget as well
Expand Down
4 changes: 1 addition & 3 deletions src/kylo/chrome/polo/content/polo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,7 @@ BrowserMonitor.prototype.openURI = function(aURI, aOpener, aWhere, aContext) {
accessKey: "C",
popup: null,
callback: function(aNotificationBar, aButton) {
// TODO this alwayss closes the last tab... not good if new tabs
// have been opened since notification was shown
browser_.closeTab(browser_.browsers_.length - 1);
browser_.closeTab(browser.getBrowserIndex());
return true;
}
}
Expand Down