Skip to content

Expose optional autoscaling fields in emr notebook - #48

Draft
santina wants to merge 1 commit into
tecton-ai:masterfrom
santina:santina/emr_autoscale
Draft

Expose optional autoscaling fields in emr notebook#48
santina wants to merge 1 commit into
tecton-ai:masterfrom
santina:santina/emr_autoscale

Conversation

@santina

@santina santina commented Jun 21, 2022

Copy link
Copy Markdown

(Haven't tested yet)

@santina santina changed the title expose optional autoscaling fields in emr notebook Expose optional autoscaling fields in emr notebook Jun 21, 2022
@santina

santina commented Jun 21, 2022

Copy link
Copy Markdown
Author

Related to #43

default = 3600
description = "Idle time in seconds after which a cluster automatically terminates."
}
variable "autoscaling_role" {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing some of these autoscaling properties are grouped together (you have to have a role if you have a policy, etc). Might be better to make a single variable who's type is an object with all of these properties as strings. That way it's very clear to end-users that you need to provide all of them if you want autoscaling, and the default for the variable can just be null to indicate no autoscaling.

Something like

var "autoscaling_config" {
type = object ({
    idle_timeout = number
    autoscaling_role = string
    autoscaling_policy = string
    })
}
default = null
description = "See https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/emr_cluster"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants