Add Finnhub API as Financial Data Fallback Provider#3
Open
kuriakosant wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bot currently relies exclusively on Yahoo Finance for all market data (prices, OHLCV history). Yahoo Finance's public chart API is unauthenticated and unofficial , it can return stale, empty, or outright wrong data during periods of rate limiting or service degradation. When it fails, get_price silently returns "No price data available", the AI has no real figures to work with, and it falls back to hallucinating stock data from its training weights.
Solution
Introduces Finnhub as a registered fallback market data provider. Finnhub is a financial data platform offering a free tier (60 requests/minute, no credit card required) with real-time stock quotes and daily OHLCV history via a stable, documented REST API.
The existing provider registry and _tool_get_price loop already support multiple providers — they iterate all registered market_data providers until one returns data. This PR slots Finnhub into that loop as the second provider, requiring zero changes to any core tool logic.