Refactor REST module to build off generic "API Response"#9
Open
Refactor REST module to build off generic "API Response"#9
Conversation
|
This reminds me of the fact that JSON API has its own What you’re doing here would also allow https://www.drupal.org/project/jsonapi to reuse this of course! |
|
I'm less certain about moving |
…8.x core releases.
…o image style via the UI
…e source plugin must use the ignore_map configuraition option if expressions are used in the query
…le via drush config-import
… views using the revision table as a base
…ew revision to false on subsequent saves
…ate and temporary directory .htaccess files
…StateInterface refers to the nonexistent property \Drupal\Core\Form\FormState::$internalStorage
…, alexpott, mikispeed, webflo, John Cook: Fix variable names in Gettext component
…ase and create kernel test version
…ondsea, mpdonadio, jhedstrom, Darvanen, bkosborne, xjm, larowlan, dkre, Lendude, effulgentsia, dawehner, alexpott: The Views integration Datetime Range fields should extend the views integration for regular Datetime fields
… temp directory from file_save_upload
…nt is incorrect/misleading
…ck when placed outside of the header
…ldForm() line 240
This reverts commit f9ca1c0.
…sing when display type Entity Reference
This reverts commit a843845.
…, svendecabooter, bdimaggio, hosef, Yogesh Pawar, heddn, quietone, alexpott, larowlan: Upgrade path for Book 6.x and 7.x
…y NEED the profiles directory to exist
… properly by ContentEntityBase::hasTranslationChanges
…, alexpott, joachim: incorrect docs in EntityTypeInterface::setAccessClass
…clickLink doesn't find the link
…mpItem FieldType annotation doc
…ormatted docs in mainPropertyName()
…er/tips page is listed by search engines
…ATE while in transaction
…al\layout_builder\Entity\LayoutBuilderEntityViewDisplayStorage into a stand-alone service or static methods
…ccess original topics data
…pping::allowsSharedTableStorage() and DefaultTableMapping::requiresDedicatedTableStorage()
…y Settings - Order the view modes based on name rather than key
…s to have customized layouts, clicking 'Layout' on full view of a node takes you to the configuration for the 'default' view mode
tedbow
force-pushed
the
move_rest_response
branch
from
d62a8c6 to
5759f53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
To provide new API response such as all available permissions we need responses that are similar to REST response by semantically they are not RESTful responses.
This is test to see what moving the logic for generic API responses out of the REST module and into \Drupal\core would look like.
Rest responses and routes would stay exactly the same but "API Response" could be extended for other types of responses such as "RPC Response"