chore(deps): ignore org.junit BOM major bumps#380
Merged
Conversation
The existing ignore rules cover org.junit.jupiter:* and org.junit.platform:* but not org.junit:junit-bom, which is what dependabot actually uses to drive junit.version updates. As a result, dependabot repeatedly opens (e.g. #377) JUnit 6 major bumps that cannot pass CI: no released maven-surefire-plugin (including 3.6.0-M1) is built against junit-platform-commons 6.x, so the forked test JVM dies with NoSuchMethodError on CollectionUtils.toUnmodifiableList(). Add org.junit:* to the ignore list until Surefire ships JUnit Platform 6 support and we do the coordinated toolchain bump the comment already describes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
org.junit:*to dependabot's ignore list for major-version bumpsorg.junit.jupiter:*andorg.junit.platform:*but missedorg.junit:junit-bom, which is the artifact dependabot actually uses to drivejunit.versionupdatesWhy
Every JUnit 6 bump PR (most recently #377) fails identically on every OS/JDK combo:
maven-surefire-plugin3.5.6 — and even the latest milestone 3.6.0-M1, verified locally on this PR branch — is built againstjunit-platform-commons1.14.x. JUnit Platform 6 removed that helper, so the forked test JVM dies before a single test runs. No released Surefire supports JUnit Platform 6 yet, so the PRs are un-mergeable upstream, not by anything we can fix here.The existing comment in
dependabot.ymlalready describes the coordinated toolchain bump this waits on (Surefire ≥ 3.x with JUnit Platform 6, drop Java 8 from CI matrix, unifyjunit.platform.versionintojunit.version). This PR just plugs the BOM artifact into the same ignore rules.Closes upstream noise from PR #377.
Test plan
.github/dependabot.yml, no code paths touched)