feat(release): add root_dir support to release-github workflow#51
Merged
feat(release): add root_dir support to release-github workflow#51
Conversation
Add root_dir input to release-github.yml so version can be read from a subdirectory manifest (e.g. n8n-node/package.json). Defaults to "." for full backwards compatibility. Pass root_dir through from build-test-publish.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
root_dirinput torelease-github.yml(default:".") so version is read from the correct subdirectory manifestdefaults.run.working-directoryaccordinglyroot_dirthrough frombuild-test-publish.ymltorelease-github.ymlMotivation
n8n-nodes-unix-socket-bridgehas itspackage.jsoninn8n-node/(not repo root). Withoutroot_dir, the release job read the wrong version and tried to create a duplicate release.Backwards compatibility
All repos not passing
root_dircontinue to work unchanged (defaults to".").