π‘οΈ Sentinel: [HIGH] Fix XSS in report generation#6
Conversation
Co-authored-by: tejasbhor <153384397+tejasbhor@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Cross-Site Scripting (XSS) in
backend/app/services/report_service.pydue to raw f-string interpolation of user-controlled variables into the HTML report string.π― Impact: A malicious user could inject arbitrary HTML or JavaScript into the generated report, leading to XSS when viewed.
π§ Fix: Used
html.escape()on all dynamic variables (e.g.layer_id,data_source,status,error_msg, alert attributes) injected into the HTML. Ensured string slicing is applied before escaping to avoid malformed HTML entities.β Verification: Ran
ruff checkand manually verified the XSS prevention using a Python script. Checked.jules/sentinel.mdupdate. Reverseduv.lockchanges.PR created automatically by Jules for task 6390400998077639152 started by @tejasbhor