Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS in report generation#6

Open
tejasbhor wants to merge 1 commit into
mainfrom
sentinel/fix-report-xss-6390400998077639152
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix XSS in report generation#6
tejasbhor wants to merge 1 commit into
mainfrom
sentinel/fix-report-xss-6390400998077639152

Conversation

@tejasbhor
Copy link
Copy Markdown
Owner

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Cross-Site Scripting (XSS) in backend/app/services/report_service.py due to raw f-string interpolation of user-controlled variables into the HTML report string.
🎯 Impact: A malicious user could inject arbitrary HTML or JavaScript into the generated report, leading to XSS when viewed.
πŸ”§ Fix: Used html.escape() on all dynamic variables (e.g. layer_id, data_source, status, error_msg, alert attributes) injected into the HTML. Ensured string slicing is applied before escaping to avoid malformed HTML entities.
βœ… Verification: Ran ruff check and manually verified the XSS prevention using a Python script. Checked .jules/sentinel.md update. Reversed uv.lock changes.


PR created automatically by Jules for task 6390400998077639152 started by @tejasbhor

Co-authored-by: tejasbhor <153384397+tejasbhor@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant