Skip to content

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in HTML report generation#8

Open
tejasbhor wants to merge 1 commit into
mainfrom
sentinel/fix-xss-html-report-14836851874452981505
Open

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in HTML report generation#8
tejasbhor wants to merge 1 commit into
mainfrom
sentinel/fix-xss-html-report-14836851874452981505

Conversation

@tejasbhor
Copy link
Copy Markdown
Owner

🛡️ Sentinel: [HIGH] Fix XSS vulnerability in HTML report generation

Severity: HIGH
Vulnerability: Cross-Site Scripting (XSS) vulnerability was present in the report_service.py where manual string interpolations built the HTML report, leaving dynamic and user-provided properties like job_id and data_source unsanitized.
Impact: An attacker could inject malicious JavaScript or HTML directly into the rendered report via user-controlled IDs and data source strings, potentially leading to session hijacking, malicious redirects, or defacement when viewing the report in a browser.
Fix: Added python's html.escape() to all dynamic string variables before rendering them in the manual f-string. To avoid an UnboundLocalError, the local html variable was renamed to html_content. Finally, ensured string slicing properly occurs before string escaping.
Verification: Verified against a custom test (test_xss.py) which ensures script and img tags are properly encoded and no longer vulnerable. Checked via ruff to ensure zero linting issues.


PR created automatically by Jules for task 14836851874452981505 started by @tejasbhor

- Added `html.escape()` to sanitize untrusted strings interpolated into HTML report logic (`report_service.py`).
- Corrected python module shadowing of the `html` built-in module by renaming the output variable to `html_content`.
- Recorded the correct truncation pattern applied when mitigating manual HTML formatting.

Co-authored-by: tejasbhor <153384397+tejasbhor@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant