🛡️ Sentinel: [HIGH] Fix XSS vulnerability in HTML report generation#9
🛡️ Sentinel: [HIGH] Fix XSS vulnerability in HTML report generation#9tejasbhor wants to merge 1 commit into
Conversation
- Imported `html` module and used `html.escape()` on all dynamic variables in `backend/app/services/report_service.py` before inserting them into HTML via f-strings. - Applied correct ordering of operations to truncate/format before escaping strings. - Added test case `backend/tests/test_report_service.py` to ensure `<script>` payloads are safely encoded. - Added critical learning log entry to `.jules/sentinel.md`. Co-authored-by: tejasbhor <153384397+tejasbhor@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: HIGH
💡 Vulnerability: The application manually generated HTML reports using Python f-strings without escaping dynamic or user-controlled variables. This omission allowed potential Cross-Site Scripting (XSS).
🎯 Impact: If malicious users manage to craft a payload in fields like
layer_id,data_sourceorerror_msg, this payload could be rendered in the browser.🔧 Fix: Wrapped all dynamic and unsanitized parameters with
html.escape()and ensured string truncation happens before escaping to avoid broken HTML entities. Added unit tests for validation.✅ Verification: Ran
uv run ruff checkanduv run pytest backend/tests/test_report_service.pysuccessfully.PR created automatically by Jules for task 4784436257481531238 started by @tejasbhor