Skip to content

Image width and height should not be forced in the component.#7

Merged
teleject merged 1 commit into
teleject:masterfrom
mvsusp:master
Mar 29, 2017
Merged

Image width and height should not be forced in the component.#7
teleject merged 1 commit into
teleject:masterfrom
mvsusp:master

Conversation

@mvsusp

@mvsusp mvsusp commented May 23, 2015

Copy link
Copy Markdown
  • The library should no be responsible to resize the component.

- The library should no be responsible to resize the component.
@teleject

teleject commented Jun 7, 2015

Copy link
Copy Markdown
Owner

@mvsusp can you clarify or describe what happens in Safari that happens with the existing code?

@Seneral

Seneral commented Jan 28, 2017

Copy link
Copy Markdown

@teleject Have the same problem @mvsusp seems to have removed these lines for.

When you resize the browser window, the images loaded with hiSrc experience strange stretching artifacts im my case. Here's a gif showing the problem ('wrong behaviour'):
hisrcresizedproblem
Reloading the page resets the images of course, but when resizing again it's still stretched.
This seems to be caused by the added width and height attributes after loading, which are specified with fixed pixels and overwrite the relative css width and height properties (but not maxWidth = 100%, hence the stretching here).
Removing these lines fixed the problem and yields the 'fixed behaviour'.

You might consider removing them too, but I can't test in Safari to see what they are supposed to fix, unfortunately. Any chance you can work around that? For now I'll simply comment these lines.
Thanks!

@mvsusp

mvsusp commented Feb 9, 2017

Copy link
Copy Markdown
Author

@Seneral is right @teleject. That is the same issue that I experienced.

@teleject

teleject commented Feb 9, 2017

Copy link
Copy Markdown
Owner

Cool. Thanks for the clarification, @Seneral and @mvsusp. Will look into it when I get a moment and more than likely update the code!

@mvsusp

mvsusp commented Feb 9, 2017 via email

Copy link
Copy Markdown
Author

@Seneral

Seneral commented Feb 9, 2017

Copy link
Copy Markdown

Great, thanks!

Also made some other changes #8 since then which solves some implementation issues of the speed test.
Did some other changes too though which may be my mere own opinion, but seem alot more apropriate to me;)

@teleject teleject merged commit 6d7acb0 into teleject:master Mar 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants