Skip to content

remove slack channel token from env configuration#66

Open
BhaskarNS-iOS wants to merge 2 commits intomainfrom
feature/remove-slack-token
Open

remove slack channel token from env configuration#66
BhaskarNS-iOS wants to merge 2 commits intomainfrom
feature/remove-slack-token

Conversation

@BhaskarNS-iOS
Copy link
Collaborator

This PR includes removal of slack channel access token from the repository

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR attempts to remove a hardcoded Slack webhook URL token from the repository's configuration files to improve security. However, the removal is incomplete, as the same token remains exposed in another file.

Changes:

  • Replaces the hardcoded Slack webhook URL in fastlane/.env with a placeholder

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

# slack settings
SLACK_ONLY_ON_FAILURE = "false"
SLACK_URL = "https://hooks.slack.com/services/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"
SLACK_URL = "https://hooks.slack.com/services/SLACK_CHANNEL_TOKEN"
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: The hardcoded Slack webhook URL token is still present in the Fastfile at line 228. While this PR removes it from the .env file, line 228 of fastlane/Fastfile contains: ENV["SLACK_URL"] = "https://hooks.slack.com/services/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". This hardcoded token completely undermines the security improvement in this PR, as the token remains exposed in the repository. Both occurrences must be removed, and the old token should be revoked and regenerated in Slack.

Additionally, the placeholder "SLACK_CHANNEL_TOKEN" is not a valid Slack webhook URL format. Consider using an environment variable approach instead (e.g., reading from environment variables set outside the repository) or using a clearer placeholder comment that explains how to configure this value properly.

Suggested change
SLACK_URL = "https://hooks.slack.com/services/SLACK_CHANNEL_TOKEN"
# Slack webhook URL must be provided via an environment variable outside this repository.
SLACK_URL = ""

Copilot uses AI. Check for mistakes.
@ShashilPohankar
Copy link
Collaborator

@BhaskarNS-iOS the changes look good, we can move ahead and merge the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants