Skip to content

build(deps-dev): align react-is with React 17 - #2536

Merged
amir-ba merged 1 commit into
telekom:mainfrom
amir-ba:copilot/scale-maintenance-20260803
Aug 3, 2026
Merged

build(deps-dev): align react-is with React 17#2536
amir-ba merged 1 commit into
telekom:mainfrom
amir-ba:copilot/scale-maintenance-20260803

Conversation

@amir-ba

@amir-ba amir-ba commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • align Storybook's direct react-is dependency with its React/React DOM 17.0.2 runtime
  • replace the incompatible React 19 major update proposed in build(deps-dev): bump react-is from 16.13.1 to 19.2.7 #2529
  • update the Yarn selector so the direct dependency reuses the existing react-is@17.0.2 resolution while React 16 transitive consumers stay unchanged

Verification

  • yarn install --frozen-lockfile
  • yarn why react-is confirms @telekom/scale-storybook-vue#react-is@17.0.2
  • repository formatting and git diff --check pass for the committed files
  • commitlint passes

The local component prerequisite build is currently blocked on pre-existing @duetds/date-picker/Stencil missing-export errors under Node 24.18.0 before Storybook starts. Exact-head CI will provide the production Storybook and visual-test proof.

Copilot AI review requested due to automatic review settings August 3, 2026 14:53
@amir-ba
amir-ba requested a review from maomaoZH as a code owner August 3, 2026 14:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the @telekom/scale-storybook-vue Storybook package’s direct react-is devDependency with its React 17 runtime, replacing the previously proposed React 19 react-is major update.

Changes:

  • Bump react-is in packages/storybook-vue/package.json from ^16.13.1 to ^17.0.2 to match react/react-dom ^17.0.2.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@amir-ba
amir-ba force-pushed the copilot/scale-maintenance-20260803 branch from d2054f5 to eb425c6 Compare August 3, 2026 15:08
Copilot AI review requested due to automatic review settings August 3, 2026 15:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.

@amir-ba
amir-ba merged commit aa6e316 into telekom:main Aug 3, 2026
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants