Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Rate limit issues #91

Description

@itsdalmo

I made a comment here #82 (comment) which I'm not sure you saw @SadriG91 and @mansn-at-telia:

Been a while since I worked on Github Apps, but I'd imagine its the Github provider and not the Github store that is being rate limited (unless you are rotating credentials for thousands of accounts, and/or very very frequently). If its the Github provider, then I don't imagine MultiApp will help since you have no control over how and when the access tokens are used - i.e. a single access token could consume the entire rate limit in a short time?

From the outset the plan was to scale Sidecred by having multiple deployments, each with their own Github App - but I take it you are still centrally managing it? Are you perhaps also using the same Github App for both the store and the provider?

I might have misunderstood something here, but it seems like using multiple apps is a somewhat brittle solution?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions