Open
Conversation
dandavison
force-pushed
the
no-logging
branch
from
7fcfbf0 to
ab35e4e
Compare
The Fail callback was routing errors through the slog logger, which meant: - Errors appeared as structured log messages (with timestamp and level) - --log-level never silently swallowed errors - --log-format json wrapped errors in JSON Errors are now always printed directly to stderr as "Error: <message>", independent of log configuration. Default log level changed from "info" to "never"; server start-dev continues to default to "warn" via its existing ChangedFromDefault override. Users can still opt in with --log-level on any command. Two deprecation warnings (namespace arg, env command args) converted from logger calls to direct stderr writes so they remain visible regardless of log level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #567
What was changed
start,listetc, as opposed to the long-runningserver start-devprocess) report errors/warnings as unstructured plain text instead of structured logging-formatted messages.server start-dev)Why?
CLIs should report errors/warnings by printing to stderr. They should not use structured logging messages for this.
How was this tested
A script to manually repro/verify this change is in the git history of this branch. It shows, for example
Scenario: Try to connect to unavailable port
Before
After
Scenario: setting env kv pairs
Before
After
[no output]