Skip to content

Replace TypeScript with-arguments import planning#38

Draft
tconley1428 wants to merge 8 commits into
dotnet_supportfrom
typescript-function-name-extractor-args
Draft

Replace TypeScript with-arguments import planning#38
tconley1428 wants to merge 8 commits into
dotnet_supportfrom
typescript-function-name-extractor-args

Conversation

@tconley1428

Copy link
Copy Markdown
Collaborator

Summary

  • replace the TypeScript-specific @nexus.typescript-with-arguments path with generic function type descriptors sourced from @nexus.function
  • remove WithArgumentsFieldSpec / PlannedFieldRole::WithArguments planning and render typed argument overloads from function metadata instead
  • carry generic import metadata on language string specs instead of precomputing imports in spec parsing
  • move TypeScript and Python import inference into their language generators
  • rename the TypeScript signal helper from converter-style signalFunctionToProto to name-extractor signalFunctionName

Generated output

  • TypeScript generated output only renames the signal helper and call site
  • No generated Python or .NET output changes

Tests

  • cargo fmt
  • cargo run -- build-examples
  • cargo test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant