Use proto-qualified service wire name for Go ServiceName#49
Draft
dplyukhin wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 23, 2026
The generated Go `ServiceName` constant is sent on the wire as the Nexus service name, so it must use the `@nexus.service-name` wire name (e.g. `temporal.api.workflowservice.v1.WorkflowService`) rather than the UpperCamelCase interface name. When `@nexus.service-name` is unspecified the wire name still defaults to the interface name, so other examples are unaffected.
dplyukhin
force-pushed
the
system-nexus-registry
branch
from
b6684a7 to
8525f9f
Compare
dplyukhin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes the generated Go
ServiceNameconstant to use the proto-qualified@nexus.service-namewire name (e.g.temporal.api.workflowservice.v1.WorkflowService) rather than theUpperCamelCase interface name.
Why
ServiceNameis sent on the wire as the Nexus service name. For system Nexusoperations the server routes by the proto-qualified service name, so the
generated constant must carry that value. When
@nexus.service-nameisunspecified the wire name still defaults to the interface name, so other
examples are unaffected.
Notes
golang(the Go-support feature branch).examples/go/workflowservice/api.goregenerated.Test plan
cargo testcargo run -- build-examples --lang goandgo build ./...inexamples/go