fix: clean up orphaned childWorkflowComplete entries on start failure#2119
Open
Malaybhai11 wants to merge 1 commit into
Open
fix: clean up orphaned childWorkflowComplete entries on start failure#2119Malaybhai11 wants to merge 1 commit into
Malaybhai11 wants to merge 1 commit into
Conversation
When a child workflow start fails or is cancelled, the childWorkflowComplete map still gets entries added. This causes memory leaks over time. Added maybeConsumeCompletion calls in the failed and cancelled branches of resolveChildWorkflowExecutionStart to clean up orphaned entries. Fixes temporalio#2000
|
|
1 similar comment
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2000
When
resolveChildWorkflowExecutionStartreceives a failed or cancelled result, thechildWorkflowCompletecompletion map still gets entries added but they are never consumed becauseresolveChildWorkflowExecutionis never called for a workflow that never started.This adds
maybeConsumeCompletioncalls in both the failed and cancelled branches to clean up orphaned entries.