Add system Nexus signalWithStartWorkflow API#2127

Draft

tconley1428 wants to merge 8 commits into

mainfrom

nexus-api-gen-signal-with-start

tconley1428 commented Jun 16, 2026

Contributor

Summary

add system Nexus TypeScript generation to build:protos using nex-gen
expose generated signalWithStartWorkflow workflow API and checked-in generated review output
serialize system Nexus envelopes with default JSON through the isolate, then protobuf-binary in the worker while applying codecs only to nested payloads
add unit and integration coverage for codec/payload converter behavior

Validation

NEX_GEN_BIN=../nexus-api-gen/target/debug/nex-gen pnpm run build:protos
pnpm --filter @temporalio/test run build:ts
pnpm -C packages/test exec ava ./lib/test-workflow-codec-runner.js
pnpm -C packages/test exec ava ./lib/test-system-nexus.js

Notes

Draft while the corresponding nex-gen TypeScript export/metadata changes are finalized and published.


          Add system Nexus signal-with-start workflow API

da9a5ac

tconley1428 force-pushed the nexus-api-gen-signal-with-start branch from 8e24cfd to da9a5ac Compare

June 16, 2026 21:03

tconley1428 mentioned this pull request

Adjust TypeScript generated exports temporalio/nex-gen#45

Open


          Merge remote-tracking branch 'origin/main' into nexus-api-gen-signal-…

00c8a59

…with-start

tconley1428 commented

View reviewed changes

scripts/gen-system-nexus.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-visitor.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts Outdated

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts

tconley1428 commented

View reviewed changes

packages/worker/src/system-nexus-payload-converter.ts Outdated

tconley1428 commented

View reviewed changes

.github/workflows/ci.yml

tconley1428 added 3 commits

June 22, 2026 16:40


          Improve system Nexus generated code validation

632eb65


          Fix pnpm lockfile protobufjs entry

29c78a8


          Merge origin/main into system Nexus PR

bc4c7d8

chris-olszewski reviewed

View reviewed changes

scripts/gen-system-nexus.ts Outdated

scripts/gen-system-nexus.ts Outdated

packages/workflow/package.json Outdated

scripts/gen-system-nexus.ts

packages/workflow/system-nexus/typescript/temporal_model_converters.ts Outdated

scripts/gen-system-nexus.ts

+                });
+              }
+              function generateWorkerVisitor(operations: OperationInfo[], messages: Map<string, MessageInfo>): void {

chris-olszewski Jun 24, 2026

Member

Unsure how I feel about this. Could we piggyback on protobufjs reflection to just directly implement this instead of generating it?

tconley1428 Jun 25, 2026

Contributor Author

We definitely could, but it isn't the path taken in every other SDK, where we generate the code for efficiency at runtime.

tconley1428 added 3 commits

June 25, 2026 10:56


          Address system Nexus generation review comments

a3fd4ba


          Update system Nexus proto path

868a0c3


          Install nex-gen in generated code CI

f5454fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet