feat(workflow): add nondeterministic unsafe.random for read-only contexts#2141
Open
xumaple wants to merge 4 commits into
Open
feat(workflow): add nondeterministic unsafe.random for read-only contexts#2141xumaple wants to merge 4 commits into
xumaple wants to merge 4 commits into
Conversation
eamsden
requested changes
Jun 25, 2026
eamsden
requested changes
Jun 25, 2026
Adds workflowInfo().unsafe.random — a nondeterministic random source (random, uuid4, fillRandom) for read-only contexts (Query handlers, update validators, interceptors), where the seed-derived random stream would otherwise repeat across evaluations. Mirrors unsafe.now: captures native Math.random before the Workflow sandbox overrides it, and strips the closures across the worker-thread boundary (reinstalling on each side without mutating the live Workflow info).
xumaple
force-pushed
the
maplexu/2110-unsafe-random
branch
from
a718100 to
fe17a65
Compare
Per PR review: toJSON returns undefined so a JSON-serialized WorkflowInfo omits unsafe.random (matching now) instead of an empty {}. Also compares the filled byte arrays with notDeepEqual.
eamsden
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
workflowInfo().unsafe.random— a nondeterministic random source (random(),uuid4(),fillRandom()) for read-only contexts (Query handlers, update validators, interceptors), where the seed-derived random stream would otherwise repeat across evaluations.It mirrors
unsafe.now: the nativeMath.randomis captured before the Workflow sandbox overrides it, and the closures are stripped across the worker-thread boundary and reinstalled on each side without mutating the live Workflow info.Fixes #2110