Populate WorkerListInfo when returning ListWorkersResponse#9418
Open
Populate WorkerListInfo when returning ListWorkersResponse#9418
Conversation
1 task
rkannan82
force-pushed
the
kannan/worker-summary-server
branch
4 times, most recently
from
05c048c to
00a7f7a
Compare
rkannan82
changed the title
rkannan82
changed the title
rkannan82
force-pushed
the
kannan/worker-summary-server
branch
3 times, most recently
from
767972c to
9906c80
Compare
## What changed? - Add workerHeartbeatToListInfo helper in frontend to convert WorkerHeartbeat to WorkerListInfo for the new ListWorkersResponse.Workers field - Update tests to verify both deprecated WorkersInfo and new Workers fields ## Why? The new WorkerListInfo proto contains only static/slow-changing worker info, enabling efficient listing of many workers without expensive dynamic data. Follows CHASM entity conventions (ActivityExecutionListInfo, ScheduleListEntry). ## How did you test it? - [x] built - [x] updated assertions in existing functional tests ## Potential risks None - backward compatible. Deprecated WorkersInfo field continues to work. Made-with: Cursor
rkannan82
force-pushed
the
kannan/worker-summary-server
branch
from
9906c80 to
603e736
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
workerHeartbeatToListInfohelper in frontend to convertWorkerHeartbeattoWorkerListInfoListWorkersResponse.workersfield withWorkerListInfofor efficient listingWorkersInfoand newWorkersfieldsWhy?
The new
WorkerListInfoproto contains only static/slow-changing worker info, enabling efficient listing of many workers without expensive dynamic data. Follows CHASM entity conventions (ActivityExecutionListInfo,ScheduleListEntry).Depends on: temporalio/api#724
How did you test it?
Potential risks
None - backward compatible. Deprecated
WorkersInfofield continues to work.