docs: use tempo mainnet chain id in examples#279
Conversation
Spec Preview
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9f7977b3b5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "methodDetails": { | ||
| "escrowContract": "0x9d136eEa063eDE5418A6BC7bEafF009bBb6CFa70", | ||
| "chainId": 42431 | ||
| "chainId": 4217 |
There was a problem hiding this comment.
Use a chain ID that matches the escrow contract
This appendix challenge now pairs chainId 4217 with escrow contract 0x9d136e..., but the deployed-contracts table in this same draft lists that address only for Moderato testnet chain 42431. Clients using this example to build the EIP-712 domain would verify/sign against the wrong network-contract pair, making the example unusable unless a 4217 deployment address is added or this example remains on 42431.
Useful? React with 👍 / 👎.
Summary