fix(request): split charge response errors by failure layer#511
Open
betterclever wants to merge 2 commits into
Open
fix(request): split charge response errors by failure layer#511betterclever wants to merge 2 commits into
betterclever wants to merge 2 commits into
Conversation
betterclever
force-pushed
the
pranjal/split-charge-rejection-errors
branch
from
July 4, 2026 14:10
1e63641 to
a1ee89a
Compare
betterclever
marked this pull request as ready for review
July 4, 2026 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #453.
PaymentErrorvariants for charge-response failures after credential submission402responses classified asPaymentRejected, matching MPP credential rejection semanticsTesting
cargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-features --locked -- -D warningscargo test --workspace --all-features --lockedRUSTDOCFLAGS='-D warnings' cargo doc --workspace --all-features --no-deps --lockedtyposNote: local
make checkcould not run literally because the Homebrewcargoin this environment does not support+nightly; the equivalent stable-toolchain fmt/clippy/test/doc gates above passed.cargo deny checkcurrently fails on existing transitivequick-xmladvisories throughtoon-format/syntect, unrelated to this PR.