Skip to content

fix(request): split charge response errors by failure layer#511

Open
betterclever wants to merge 2 commits into
tempoxyz:mainfrom
betterclever:pranjal/split-charge-rejection-errors
Open

fix(request): split charge response errors by failure layer#511
betterclever wants to merge 2 commits into
tempoxyz:mainfrom
betterclever:pranjal/split-charge-rejection-errors

Conversation

@betterclever

@betterclever betterclever commented Jun 24, 2026

Copy link
Copy Markdown

Summary

Fixes #453.

  • add typed PaymentError variants for charge-response failures after credential submission
  • keep 402 responses classified as PaymentRejected, matching MPP credential rejection semantics
  • classify non-402 4xx responses as application-layer payment response errors, and 5xx responses as server-layer payment response errors

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets --all-features --locked -- -D warnings
  • cargo test --workspace --all-features --locked
  • RUSTDOCFLAGS='-D warnings' cargo doc --workspace --all-features --no-deps --locked
  • typos

Note: local make check could not run literally because the Homebrew cargo in this environment does not support +nightly; the equivalent stable-toolchain fmt/clippy/test/doc gates above passed. cargo deny check currently fails on existing transitive quick-xml advisories through toon-format/syntect, unrelated to this PR.

@betterclever betterclever changed the title Split charge rejection errors by failure layer Split charge response errors by MPP failure layer Jun 24, 2026
@betterclever
betterclever force-pushed the pranjal/split-charge-rejection-errors branch from 1e63641 to a1ee89a Compare July 4, 2026 14:10
@betterclever betterclever changed the title Split charge response errors by MPP failure layer fix(request): split charge response errors by failure layer Jul 4, 2026
@betterclever
betterclever marked this pull request as ready for review July 4, 2026 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tempo-request: split PaymentRejected by failure layer for actionable error reporting

1 participant