Skip to content

Resolve clippy collapsible_if findings in multiple modules#124

Merged
sergio-ivanuzzo merged 1 commit into
primaryfrom
codex/fix-code-scanning-issues
Apr 28, 2026
Merged

Resolve clippy collapsible_if findings in multiple modules#124
sergio-ivanuzzo merged 1 commit into
primaryfrom
codex/fix-code-scanning-issues

Conversation

@sergio-ivanuzzo

Copy link
Copy Markdown
Member

Motivation

  • Address code-scanning warnings from clippy about collapsible nested if/if let patterns in input handling and buffered message retrieval to improve code clarity and satisfy lint rules.

Description

  • Refactored JsonNavigator Up/Down handlers to combine nested if checks into a single condition while preserving the moved flag and scroll behavior (src/plugins/tui/components/json_navigator/mod.rs).
  • Collapsed sequential checks for reading and parsing a user input line into a chained if let to simplify the interactive choice flow (src/plugins/dbg_ui/mod.rs).
  • Combined nested if let checks in OrderedReceiver::recv into a chained if let to simplify buffered entry retrieval (src/client/types.rs).

Testing

  • Ran cargo fmt --all and cargo fmt --all -- --check successfully with no formatting issues.
  • Attempted cargo clippy --all-targets --all-features -q, but the run failed due to an environment network error when downloading https://index.crates.io/config.json (HTTP 403 via CONNECT tunnel), so clippy could not be fully validated.
  • Verified local formatting and non-network validation steps completed without errors.

Codex Task

@sergio-ivanuzzo sergio-ivanuzzo merged commit a5511eb into primary Apr 28, 2026
3 checks passed
@sergio-ivanuzzo sergio-ivanuzzo deleted the codex/fix-code-scanning-issues branch April 28, 2026 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant