Resolve clippy collapsible_if findings in multiple modules#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
if/if letpatterns in input handling and buffered message retrieval to improve code clarity and satisfy lint rules.Description
JsonNavigatorUp/Down handlers to combine nestedifchecks into a single condition while preserving themovedflag and scroll behavior (src/plugins/tui/components/json_navigator/mod.rs).if letto simplify the interactive choice flow (src/plugins/dbg_ui/mod.rs).if letchecks inOrderedReceiver::recvinto a chainedif letto simplify buffered entry retrieval (src/client/types.rs).Testing
cargo fmt --allandcargo fmt --all -- --checksuccessfully with no formatting issues.cargo clippy --all-targets --all-features -q, but the run failed due to an environment network error when downloadinghttps://index.crates.io/config.json(HTTP 403 via CONNECT tunnel), so clippy could not be fully validated.Codex Task