Skip to content

chore: remove dead pass statement in db.py TYPE_CHECKING block#84

Merged
tenfourty merged 1 commit intomainfrom
cyrus/ten-1-find-a-small-improvement
Apr 27, 2026
Merged

chore: remove dead pass statement in db.py TYPE_CHECKING block#84
tenfourty merged 1 commit intomainfrom
cyrus/ten-1-find-a-small-improvement

Conversation

@cyrusagent
Copy link
Copy Markdown
Contributor

@cyrusagent cyrusagent Bot commented Apr 27, 2026

Assignee: jeremy

Summary

Removes a dead pass statement inside the if TYPE_CHECKING: block in src/kb/db.py. The block already imports Path, so the pass is unreachable and was leftover from a refactor.

 if TYPE_CHECKING:
     from pathlib import Path

-    pass
-
 EMBEDDING_DIM = 1024

Why

Pure no-op cleanup — the pass is dead code (a TYPE_CHECKING block with at least one import doesn't need it). No behavior change, no test changes.

Linear

Closes TEN-1 — "Find a small improvement".

Test plan

  • File parses (python3 -c "import ast; ast.parse(...)")
  • CI runs ruff + mypy + pytest on the diff (no logic changed, expected to pass)

Tip: I will respond to comments that @ mention @cyrusagent on this PR. You can also submit a review with all your feedback at once, and I will automatically wake up to address each comment.

The TYPE_CHECKING block already imports Path; the trailing `pass`
is unreachable leftover from a refactor. Pure no-op cleanup.
@tenfourty tenfourty merged commit 523c5d7 into main Apr 27, 2026
7 checks passed
@tenfourty tenfourty deleted the cyrus/ten-1-find-a-small-improvement branch April 27, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant