chore: remove dead pass statement in db.py TYPE_CHECKING block#84
Merged
chore: remove dead pass statement in db.py TYPE_CHECKING block#84
Conversation
The TYPE_CHECKING block already imports Path; the trailing `pass` is unreachable leftover from a refactor. Pure no-op cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assignee: jeremy
Summary
Removes a dead
passstatement inside theif TYPE_CHECKING:block insrc/kb/db.py. The block already importsPath, so thepassis unreachable and was leftover from a refactor.if TYPE_CHECKING: from pathlib import Path - pass - EMBEDDING_DIM = 1024Why
Pure no-op cleanup — the
passis dead code (aTYPE_CHECKINGblock with at least one import doesn't need it). No behavior change, no test changes.Linear
Closes TEN-1 — "Find a small improvement".
Test plan
python3 -c "import ast; ast.parse(...)")