Skip to content

fix: correct flag labels and typos per issue #133 - #134

Merged
jjezewski merged 1 commit into
tennaproject:mainfrom
Jah-yee:fix/flag-label-typos
Aug 8, 2026
Merged

fix: correct flag labels and typos per issue #133#134
jjezewski merged 1 commit into
tennaproject:mainfrom
Jah-yee:fix/flag-label-typos

Conversation

@Jah-yee

@Jah-yee Jah-yee commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes 3 issues from issue #133:

  1. ENCOUNTER_OUTCOMES labels 1 and 2 swapped: Per the issue reporter's Deltarune save data analysis, the Spamton NEO encounter outcome labels were backwards (1=Spared in actual game data, not Violenced). Swapped labels 1 and 2 in the ENCOUNTER_OUTCOMES map.

  2. FRIEND_INTERACTED grammar fix: 'was damaged' -> 'were damaged' (subject is plural 'you')

  3. PLATFORMING_INTRO_ATTACK_WALL displayName: 'Attack wall' -> 'Attacked wall' (displayName now matches past-tense description)

Testing

  • TypeScript syntax verified (no errors)
  • No logic changes, only label/description corrections
  • Matches fix description in issue Minor typos #133

Files changed

  • src/data/flags.ts (ENCOUNTER_OUTCOMES swap + FRIEND_INTERACTED grammar)
  • src/data/flag-bitfields.ts (Attack wall -> Attacked wall)

- Swap ENCOUNTER_OUTCOMES labels 1 and 2: based on issue reporter's
  save data, values were swapped (1=SnowGrave-route=Violenced,
  not 1=peaceful)
- FRIEND_INTERACTED: 'was damaged' -> 'were damaged' (grammar fix)
- PLATFORMING_INTRO_ATTACK_WALL: 'Attack wall' -> 'Attacked wall'
  (displayName now matches past-tense description)

Fixes tennaproject#133
@jjezewski

Copy link
Copy Markdown
Member

Thanks for contributing!

@jjezewski
jjezewski merged commit 874ca5f into tennaproject:main Aug 8, 2026
1 check failed
github-actions Bot added a commit that referenced this pull request Aug 8, 2026
jjezewski added a commit that referenced this pull request Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants