[ttl] Add eq, ne, gt and lt ops#450
Conversation
080ce06 to
71baf21
Compare
71baf21 to
65fb850
Compare
|
With this approach I hit a catastrophic cancellation . |
|
So excited to use these! Thank you, Vlad!
Maybe we can reduce the PCC for these ops? This seems fine within bf16 tolerance |
|
Thanks, @zoecarver ! I decided to go with the proper comparison. There is a tt-metal PR tenstorrent/tt-metal#41304 and I'm afraid that I'll have to commit to tt_llk. So this PR is in draft. |
|
PR tenstorrent/tt-metal#41304 merged, now tt-metal has a great support for comparison OPs. |
1311000 to
df5d400
Compare
[ttl] Add FP32 eq, ne, gt and lt ops
How?
By using corresponding ttnn ops.
Test method changed. ULP and PCC are not applicable to bool output. 1 ≠ 0.
So a new boolean comparison function introduced.
Only FP32 is supported for now. Bf16 should be added in tt-metal first.
Dependency
tenstorrent/tt-metal#41304
How to Test?
Checklist: