Improve parallel suite scheduling and correctness#33
Conversation
Add min_jobs field to parallel suites so they can declare the minimum job count required for correct execution. Validate this upfront and fail fast if underprovisioned. Prioritize parallel suite execution over standalone tests to ensure interdependent test groups start together. Warn when parallel suites have more tests than available jobs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae651341a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2ef56a2b1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16f87cd656
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa1da6f236
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
Summary
Parallel suite scheduling improvements to prevent concurrency bugs and ensure correct test execution:
Suite prioritization: Workers now dequeue parallel suites before standalone tests, ensuring interdependent test groups (e.g., publisher/subscriber pairs) start together instead of being delayed by unrelated test backlogs
min_jobscorrectness guard: Parallel suites can declaremin_jobsintest.yamlto specify the minimum--jobsvalue required for correct execution. The harness fails fast with a clear error if--jobsis too lowOversubscription warning: When a parallel suite has more tests than available jobs, the harness emits a warning so users know effective parallelism is capped
Slot acquisition improvements: Parallel suites acquire all slots upfront and run members without per-member slot acquisition. New synchronization primitives (
slot_lockandqueue_lock) prevent races when multiple workers share slot budgets and work queuesDocumentation
Companion docs PR: tenzir/docs#227
Test Plan
_validate_parallel_suite_min_jobs,_warn_parallel_suite_oversubscription,_pop_next_queue_item🤖 Generated with Claude Code