decrease earliest epoch value of query xml by 3 hours query XML - #415
Open
elliVM wants to merge 11 commits into
Open
decrease earliest epoch value of query xml by 3 hours query XML#415elliVM wants to merge 11 commits into
elliVM wants to merge 11 commits into
Conversation
Contributor
Author
Member
|
please rebase |
elliVM
force-pushed
the
timestamp-epoch-minus-three-hours
branch
from
November 15, 2024 09:39
1551c09 to
bfeceed
Compare
Contributor
Author
|
Rebased |
Contributor
|
I think you also need to change it for the produced XML and spark column to have an effect |
eemhu
reviewed
Nov 15, 2024
elliVM
marked this pull request as draft
November 15, 2024 11:34
elliVM
marked this pull request as ready for review
November 18, 2024 08:06
51-code
suggested changes
Nov 18, 2024
eemhu
reviewed
Nov 18, 2024
eemhu
left a comment
eemhu
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but should EqualsVerifier be added to pth-10 as well for hashCode tests?
Member
yes, please add @elliVM |
kortemik
requested changes
Nov 20, 2024
Contributor
Author
|
Added EqualsVerifier library and contract test. |
elliVM
force-pushed
the
timestamp-epoch-minus-three-hours
branch
from
January 21, 2025 12:40
94ee229 to
351832d
Compare
Contributor
Author
|
Rebased and duplicate dependency removed |
kortemik
requested changes
Apr 24, 2025
| ); | ||
| final ElementNode returnValue; | ||
| if (timeQualifier.isStartTime()) { | ||
| final long decreaseValue = 3 * 60 * 60 * 1000; // decrease 3 hours from earliest |
Member
There was a problem hiding this comment.
please make this configurable:
dpl.pth_10.logicalstatement.TimeStatement.xmlDecreaseStartTime=true
check that all paths parts to the key are defined as this is an optional key i.e.
hasKey(dpl.pth_10.logicalstatement) && hasKey(dpl.pth_10.logicalstatement.TimeStatement) && hasKey(dpl.pth_10.logicalstatement.TimeStatement.xmlDecreaseStartTime)
elliVM
force-pushed
the
timestamp-epoch-minus-three-hours
branch
from
May 19, 2025 06:53
ccc94ba to
2319474
Compare
Contributor
Author
|
rebased and update code, further changes required after #572 |
…dd EqualsVerifier and contract test
elliVM
force-pushed
the
timestamp-epoch-minus-three-hours
branch
from
June 12, 2025 05:47
d509b51 to
5037b98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround to decrease earliest epoch value given to query XML by 3 hours to work with pth_06 that uses helsinki timezone.