Skip to content

Establish the AI-first base for tesote/seven_zip_ruby - #2

Open
developerz-ai[bot] wants to merge 1 commit into
masterfrom
dz/onboarding
Open

developerz-ai[bot] wants to merge 1 commit into
masterfrom
dz/onboarding

Conversation

@developerz-ai

@developerz-ai developerz-ai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

This pull request establishes the base an AI coding agent needs to work well in tesote/seven_zip_ruby.

Stack

Detected Ruby + Bundler from the repository's own files.

Established

  • bin/setup — 4. scripts that work
  • bin/dev — 4. scripts that work
  • bin/check — 4. scripts that work
  • CLAUDE.md — 1. a brain
  • .claude/agents/native-glue.md — 2. a specialist roster
  • .claude/agents/archive-api.md — 2. a specialist roster
  • .claude/skills/verify-change/SKILL.md — 3. project skills
  • .claude/skills/build-native-extension/SKILL.md — 3. project skills
  • AGENTS.md
  • docs/README.md
  • .claude/commands/planx.md — 9. workflow commands
  • .claude/commands/feature.md — 9. workflow commands
  • .githooks/pre-commit — 4. scripts that work
  • .mcp.json — 5. agent wiring
  • .dz/maintainer/maintainer.yml — 0. the repo policy
  • .dz/maintainer/reviewer.md — 0. the repo policy
  • .dz/onboarding/scorecard.md

Left alone

These already existed and are yours — nothing here was rewritten, reordered or reflowed:

  • .github/workflows/ci.yml — 4. scripts that work
  • .gitignore

Verification

The gate this pull request declares, run on the box that wrote it: bin/setup then bin/check, before these changes (base) and after them (head).

Proof: unprovable — bin/check did not run green at head on this box. Nothing in the repository’s own code was changed to force it; the excerpt below is the record.

  • ./bin/setup absent at base
  • ./bin/check absent at base
  • ./bin/setup exited 0 at head (0.3s)
    Bundle complete! 4 Gemfile dependencies, 9 gems now installed.
    Use `bundle info [gemname]` to see where a bundled gem is installed.
    
    mise all tools are installed
    
  • ./bin/check at head: red, exit 1 (70.6s)
    warning: ISO C++ forbids converting a string constant to ‘LPOLESTR’ {aka ‘wchar_t*’} [-Wwrite-strings]
      439 |   { L"Saved State", kpidSavedState, VT_BOOL},
          |     ^~~~~~~~~~~~~~
    make
    #<Thread:0x00007ae0bed05fb0 /home/dz-agent/workspace-ai/tesote/tesote/seven_zip_ruby/spec/seven_zip_ruby_spec.rb:287 aborting> terminated with exception (report_on_exception is true):
    Interrupted (StandardError)
    

Scorecard

10 of 15 items ok. The whole card, with every piece of evidence, is .dz/onboarding/scorecard.md.

  • policy — ok — .dz/maintainer/maintainer.yml established
  • brain — ok — CLAUDE.md established
  • roster — ok — .claude/agents/native-glue.md established
  • skills — ok — .claude/skills/verify-change/SKILL.md established
  • scripts — ok — bin/setup established
  • wiring — ok — .mcp.json established
  • commands — ok — .claude/commands/planx.md established
  • access — gap — asked for 0 credentials
  • layout — gap — migration to the house layout filed as tasks
  • smoke_test — unprovable — spec/seven_zip_ruby_spec.rb in the repository
  • env_example — gap — nothing recorded
  • agents_md — ok — AGENTS.md established
  • per_workspace_brains — ok — single-package repository: 0 workspaces
  • docs_readme — ok — docs/README.md established
  • gate_proved — unprovable — ./bin/check at head: red, exit 1 (70.6s)

First tasks

Queued from what this pass found, and none of them runs before this merges:

  • Verify the base runs clean
  • Align bin/check with the existing CI pipeline (proposal)
  • Move the application into apps/seven-zip-ruby (house layout)

Merging

This rewrites how agents read your repo, on a repo the platform has not worked before,
so it is yours to merge — not the bot's. Merging it is also what marks the repo
onboarded; until then coding tasks on it are held (issue triage, PR review and
report-only tasks are unaffected).


🤖 Opened by developerz.ai for task tsk_70b5f5f18bc9150c721795cb6d2479c5 on tesote/seven_zip_ruby.

Raised automatically by the repo-onboarding lane, from an interactive repository setup session.

🤖 developerz.ai maintainer bot — this PR is one slice of a stacked plan.
Dispatched automatically by the repo-onboarding lane
Ran on box Brave Zephyr
Cost unknown: no list price on record for z-ai/glm-5.3 on openrouter.ai
Run timeline run_553e9c7027ea4d05a8054f6811d82a39
Part 1/1 of plan tsk_70b5f5f18bc9150c721795cb6d2479c5


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Dz-Task-Id: tsk_70b5f5f18bc9150c721795cb6d2479c5
@developerz-ai developerz-ai Bot added the dz/fleet-pr Opened by the developerz.ai maintainer bot from a fleet run. label Sep 18, 2026
@developerz-ai

developerz-ai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown
Author

🟡 Reviewed

5 actionable comment(s) · 1 refuted by verification · 10 suppressed (anti-noise) · grounded on your code

⚠️ 1 config note(s): test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

⏱ 3m 32s wall clock · z-ai/glm-5.3-flash via openrouter · 25 model call(s) · 13,834 output token(s) · 18 tok/s observed (slowest call 1m 31s)

🤖 developerz.ai — automated review, running on your model and your box.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 4a930740-3bc3-4bb1-941e-aafa29957213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@developerz-ai developerz-ai Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary — 18 file(s), 5 finding(s).

Critical 0 · Major 1 · Minor 4 · Nit 0

agent-tooling-and-config

Agent-tooling scaffolding for the gem; bin/setup has a set -e bug that aborts install when mise is absent, and the PR's own gate (bin/check) is red at head, so nothing is proven.

concern-api-contract

No public API or stored contract changes; one internal contract mismatch — bin/check does not honor the exit-75 convention the new verify-change skill documents for it.

concern-style-nits

The added docs/scripts are consistent except that verify-change/SKILL.md asserts a pre-commit hook and an exit-75 precondition contract that bin/check and the opt-in hook never implement.

agent-tooling-and-config (handoff)

Onboarding scaffolding is mostly consistent, but bin/setup aborts under set -e on boxes without mise, and the verify-change skill documents exit-code behavior bin/check does not implement; the gate itself is recorded red at head.

No findings from: concern-security (nothing to review: The diff is documentation, workflow scripts and agent configuration. The only credential references (.mcp.json SENTRY_ACCESS_TOKEN, DEVELOPERZ_API_KEY) are env-variable placeholders, not embedded secrets; no executable code touches untrusted input, auth, or privileged operations.), concern-tests.

File Findings
.claude/skills/verify-change/SKILL.md 3 minor
.dz/onboarding/scorecard.md 1 minor
bin/setup 1 major

1 candidate finding(s) refuted by verification (each was judged against the diff and did not hold).

10 lower-signal comment(s) suppressed (anti-noise: 8 duplicate, 1 restated across files, 1 below floor).

Config notes
  • test files were not shown to the reviewer — this diff touched no path recognised as a test, so no assertion was available to read the change against

🤖 developerz.ai review — automated, running on your model and your box. What is this?
Reviewed by openrouter/z-ai/glm-5.3-flash on box Azure Mole — 504k in / 13.8k out over 25 calls, ~$0.08 on your key (estimate: list price x reported tokens).

Comment on lines +12 to +13
`bin/check` is the gate. CI runs it and the pre-commit hook runs it, so a change that
passes it locally passes everywhere.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs This claims 'the pre-commit hook runs it', but the hook in .githooks/pre-commit only runs after git config core.hooksPath .githooks, which a fresh clone has not done — so a change passing locally does not automatically pass a hook everywhere. Say the hook must be activated per clone.

grounded: .claude/skills/verify-change/SKILL.md, ext/p7zip/CPP/Common/TextConfig.cpp:124, ext/p7zip/CPP/Common/TextConfig.cpp … · 🤖 developerz.ai review — automated, what is this?

Comment on lines +30 to +36
red. Exit 1 cannot carry that difference, so one code is reserved:

| Exit | Means | What the platform does |
|------|-------|------------------------|
| 0 | the change passes | commit it |
| 75 | a resource the gate NEEDS is unreachable (a database, a service, a credential) — it refused to grade | refuse the commit, and blame the environment, never the change |
| any other non-zero | the gate ran and the change is red | refuse the commit, and blame the change |

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The skill mandates bin/check reserve exit 75 for unreachable resources and guard preconditions first, but bin/check (bin/check:3-5) is plain set -euo pipefail with no 75 path, so the documented contract is unimplemented. Either add the guard to bin/check or reword the skill as aspirational. Also at .claude/skills/verify-change/SKILL.md:26.

grounded: ext/p7zip/CPP/7zip/Archive/7z/7zIn.h:61, ext/p7zip/CPP/7zip/Archive/7z/7zIn.cpp:1068, ext/p7zip/CPP/Common/MyVector.cpp:36 … · 🤖 developerz.ai review — automated, what is this?

| 75 | a resource the gate NEEDS is unreachable (a database, a service, a credential) — it refused to grade | refuse the commit, and blame the environment, never the change |
| any other non-zero | the gate ran and the change is red | refuse the commit, and blame the change |

- Guard preconditions FIRST and `exit 75` when one is unmet. `exit 1` there tells the

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · docs The skill mandates that bin/check exit 75 on unmet preconditions, but bin/check (lines 1-5) has no precondition guard and can only exit 0 or the failing command's code, so the documented contract is never met. Either add the guard to bin/check or drop the 75 row from this table.

grounded: .claude/skills/verify-change/SKILL.md, ext/p7zip/CPP/7zip/Common/StreamBinder.cpp:24, ext/p7zip/CPP/7zip/Common/StreamBinder.cpp … · 🤖 developerz.ai review — automated, what is this?

Comment on lines +76 to +78
## `gate_proved` — unprovable

- ./bin/check at head: red, exit 1 (70.6s)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor · completeness This PR merges the repo's onboarding config while its own scorecard records gate_proved: unprovable — bin/check exited 1 at head (spec aborted with 'Interrupted'), so the gate these files declare is not proven green. Per reviewer.md the multi_thread timing spec is a known flake; re-run bin/check and update the scorecard (or note the flake as the cause) so the merged record is accurate.

grounded: .dz/onboarding/scorecard.md, ext/p7zip/CPP/Common/MyWindows.h:70, ext/p7zip/CPP/7zip/Archive/Zip/ZipHandlerOut.cpp … · 🤖 developerz.ai review — automated, what is this?

Comment thread bin/setup
# one-command setup — established by dz-runner setup mode. One command; adjust as the repo grows.
set -euo pipefail
cd "$(dirname "$0")/.."
command -v mise >/dev/null && mise install

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

major · bug With set -e, the line command -v mise >/dev/null && mise install exits the script non-zero when mise is absent, so bundle install never runs on machines without mise — the very case the guard is for. Make it an if-statement so mise being missing is a no-op.

Suggested change
command -v mise >/dev/null && mise install
if command -v mise >/dev/null; then
mise install
fi
bundle install

grounded: ext/p7zip/CPP/7zip/Archive/7z/7zIn.cpp:157, ext/p7zip/CPP/7zip/Archive/7z/7zIn.cpp, ext/p7zip/CPP/7zip/Archive/Udf/UdfIn.cpp … · 🤖 developerz.ai review — automated, what is this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dz/fleet-pr Opened by the developerz.ai maintainer bot from a fleet run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants