fix(ci): bump vitest testTimeout to 15s — close P0-6 from launch-eve audit - #1
Merged
Conversation
…audit http-transport.test.ts has been failing on every GitHub Actions main run since v0.1.0, including the v0.1.0 / v0.1.1 / v0.1.2 tag pushes. Six tests time out at 5000ms in the CI Ubuntu environment while the same six pass in ~70ms total locally on Windows. Root cause: the file drives `runHttpServer(config)` which calls `app.listen(0, '127.0.0.1', cb)` on Express 5; the CI runner's listen-callback latency is enough to push past the vitest default 5000ms in some of the more lifecycle-heavy tests. The in-test work itself is sub-100ms once bind completes. Adopts `testTimeout: 15000` and `hookTimeout: 15000` at the vitest config level. Local fast runs are unaffected. The CI badge on the repo should go green on the next push instead of carrying a red X for HN visitors clicking through from npm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
Launch-eve audit (2026-05-27) P0-6 —
tests/http-transport.test.tshas been failing on every GitHub Actions main run since v0.1.0 including the v0.1.0 / v0.1.1 / v0.1.2 tag pushes. Six of the 13 tests time out at the vitest default 5000ms on the CI Ubuntu runner. Locally the same six pass in ~70ms total.Diagnosis
The tests drive
runHttpServer(config)which callsapp.listen(0, '127.0.0.1', cb)on Express 5. The CI runner's listen-callback latency is enough to push past the 5000ms vitest default on a few lifecycle-heavy tests (each test does start-server + driver-fetch + close-server). The work inside the tests themselves is sub-100ms once bind completes.Fix
Adopts
testTimeout: 15000andhookTimeout: 15000at the vitest config level. Local fast runs are unaffected.Verification
npm test: 68/68 passing, full suite 584ms (http-transport file alone 62ms — well inside the new ceiling, with plenty of headroom for the slower CI environment)