Fix PowerShell syntax in Windows build workflow#13
Merged
Conversation
The || operator and 'true' are bash idioms that don't work in Windows PowerShell 5.1 (shell: powershell). Switch to pwsh (PowerShell 7) which supports the || pipeline chain operator, and replace bare 'true' with '$true' (PowerShell boolean literal). https://claude.ai/code/session_015XDgrfp3HkuA7jyLE8gP5w
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed PowerShell syntax errors in the Windows build workflow that would cause the release cleanup step to fail.
Key Changes
2>$null || trueto2>$null || $trueto use proper PowerShell boolean syntax (the$trueautomatic variable instead of the bashtruecommand)powershelltopwshfor consistency with modern PowerShell Core usageDetails
The original syntax used
truewhich is a bash command and not recognized in PowerShell. The corrected syntax uses$true, which is PowerShell's built-in boolean constant. The shell change frompowershelltopwshensures the workflow uses PowerShell Core, which is the recommended shell for GitHub Actions on Windows runners.https://claude.ai/code/session_015XDgrfp3HkuA7jyLE8gP5w