Add robust crash logging and dual-exe Windows build support#17
Merged
Conversation
Root cause: the exe was built with console=False (GUI subsystem) but the entry point required an argparse subcommand. Double-clicking the exe provided no args, causing argparse to call sys.exit(2) with the error message going to invisible stderr. The process appeared in Task Manager briefly and then vanished with no visible output. Changes: - __main__.py: add bootstrap crash logging to %LOCALAPPDATA%\venting\logs\ and a Windows MessageBox on fatal errors; when running as a frozen exe with no args, launch the GUI directly instead of requiring a subcommand - venting.spec: add PySide6 plugin/translation data collection and dynamic libs to prevent Qt platform plugin failures; widen UPX exclusions to cover all Qt/PySide6 binaries (*.pyd, Qt6*.dll, pyside6*.dll) - venting_cli.spec: new spec for a console=True CLI executable - build_windows.py: build both venting.exe (GUI) and venting_cli.exe (CLI); support --gui-only, --cli-only, and --debug flags - build_windows.yml: add smoke tests (--help and gate --single) for the CLI exe; publish both artifacts in the release - .gitignore: add build/ and dist/ https://claude.ai/code/session_015sYv5NFMoDqEA1J6yV757i
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds early-stage crash logging to the bootstrap entry point and implements a dual-executable Windows build system (GUI and CLI), with automatic GUI launch for frozen builds with no arguments.
Key Changes
Bootstrap & Crash Logging (
src/venting/__main__.py)%LOCALAPPDATA%\venting\logs\boot.log(or platform equivalent)crash.logfor debugging silent failuresDual Windows Executables
console=False, launches GUI directly on double-clickconsole=True, CLI-only executable for terminal usageBuild System (
build_windows.py)--gui-only,--cli-only,--debugflagsbuild_spec()function--log-level=DEBUGCI/CD Updates (
.github/workflows/build_windows.yml)venting_cli.exe --helpandventing_cli.exe gate --singleventing.exeandventing_cli.exeas release assetsDocumentation
.gitignoreentries forbuild/anddist/directoriesImplementation Details
sys.frozenattribute set by PyInstallerhttps://claude.ai/code/session_015sYv5NFMoDqEA1J6yV757i