Skip to content

fix: 11 verified bugs from codebase audit#19

Merged
test1card merged 1 commit into
mainfrom
claude/audit-review-prioritize-lhTuD
Mar 1, 2026
Merged

fix: 11 verified bugs from codebase audit#19
test1card merged 1 commit into
mainfrom
claude/audit-review-prioritize-lhTuD

Conversation

@test1card

Copy link
Copy Markdown
Owner

Critical fixes:

  • thermo.py: fix u_air() broken energy equation (h-u=RT, not R(T-T_ref))
    that caused variable thermo mode to underestimate cooling by 162x
  • cli.py: fix MC command swapping N_par and n_int_per_interface, which
    halved orifice area vs sweep/thermal commands

Medium fixes:

  • flow.py: add laminar-turbulent blending zone (Re 2000-4000) to eliminate
    75% discontinuity in friction factor at Re=2300
  • solver.py: add terminal events to solve_case_stream() to prevent
    negative mass and enable early stopping (matching solve_case behavior)
  • profiles.py: change table profile 200-2000 Pa guard from raise to
    warning (was blocking legitimate low-pressure data)
  • profiles.py: enforce p_floor in barometric profile and add input guards
  • validity.py: use T0 instead of node T for Knudsen check on reverse flow
    from external boundary

Low fixes:

  • validity.py: dispatch to mdot_fanno_tube for Fanno edges in validity
  • compare.py: handle shape mismatch in compare_runs for different topologies
  • io.py: fix fallback version from "9.0.0" to "10.0.0"
  • solver.py: improve _property_model error message for isothermal mode

Tests updated:

  • test_v9_features.py: extend variable thermo test to 0.3s with T check
  • test_validity_and_units.py: expect warning instead of ValueError
  • test_solver_stream.py: allow early termination in chunk count assertion

https://claude.ai/code/session_01PwDxpNDVJXVejy1rSoCUsS

Critical fixes:
- thermo.py: fix u_air() broken energy equation (h-u=R*T, not R*(T-T_ref))
  that caused variable thermo mode to underestimate cooling by 162x
- cli.py: fix MC command swapping N_par and n_int_per_interface, which
  halved orifice area vs sweep/thermal commands

Medium fixes:
- flow.py: add laminar-turbulent blending zone (Re 2000-4000) to eliminate
  75% discontinuity in friction factor at Re=2300
- solver.py: add terminal events to solve_case_stream() to prevent
  negative mass and enable early stopping (matching solve_case behavior)
- profiles.py: change table profile 200-2000 Pa guard from raise to
  warning (was blocking legitimate low-pressure data)
- profiles.py: enforce p_floor in barometric profile and add input guards
- validity.py: use T0 instead of node T for Knudsen check on reverse flow
  from external boundary

Low fixes:
- validity.py: dispatch to mdot_fanno_tube for Fanno edges in validity
- compare.py: handle shape mismatch in compare_runs for different topologies
- io.py: fix fallback version from "9.0.0" to "10.0.0"
- solver.py: improve _property_model error message for isothermal mode

Tests updated:
- test_v9_features.py: extend variable thermo test to 0.3s with T check
- test_validity_and_units.py: expect warning instead of ValueError
- test_solver_stream.py: allow early termination in chunk count assertion

https://claude.ai/code/session_01PwDxpNDVJXVejy1rSoCUsS
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@test1card
test1card merged commit 5f2b31b into main Mar 1, 2026
6 checks passed
@test1card
test1card deleted the claude/audit-review-prioritize-lhTuD branch March 1, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants