fix: 11 verified bugs from codebase audit#19
Merged
Conversation
Critical fixes: - thermo.py: fix u_air() broken energy equation (h-u=R*T, not R*(T-T_ref)) that caused variable thermo mode to underestimate cooling by 162x - cli.py: fix MC command swapping N_par and n_int_per_interface, which halved orifice area vs sweep/thermal commands Medium fixes: - flow.py: add laminar-turbulent blending zone (Re 2000-4000) to eliminate 75% discontinuity in friction factor at Re=2300 - solver.py: add terminal events to solve_case_stream() to prevent negative mass and enable early stopping (matching solve_case behavior) - profiles.py: change table profile 200-2000 Pa guard from raise to warning (was blocking legitimate low-pressure data) - profiles.py: enforce p_floor in barometric profile and add input guards - validity.py: use T0 instead of node T for Knudsen check on reverse flow from external boundary Low fixes: - validity.py: dispatch to mdot_fanno_tube for Fanno edges in validity - compare.py: handle shape mismatch in compare_runs for different topologies - io.py: fix fallback version from "9.0.0" to "10.0.0" - solver.py: improve _property_model error message for isothermal mode Tests updated: - test_v9_features.py: extend variable thermo test to 0.3s with T check - test_validity_and_units.py: expect warning instead of ValueError - test_solver_stream.py: allow early termination in chunk count assertion https://claude.ai/code/session_01PwDxpNDVJXVejy1rSoCUsS
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical fixes:
that caused variable thermo mode to underestimate cooling by 162x
halved orifice area vs sweep/thermal commands
Medium fixes:
75% discontinuity in friction factor at Re=2300
negative mass and enable early stopping (matching solve_case behavior)
warning (was blocking legitimate low-pressure data)
from external boundary
Low fixes:
Tests updated:
https://claude.ai/code/session_01PwDxpNDVJXVejy1rSoCUsS