Skip to content

DO NOT MERGE: probe the consolidated on-pr-ts-nx producer - #4489

Closed
sidj-thr wants to merge 2 commits into
mainfrom
tmp-nx-draftfix-probe
Closed

sidj-thr wants to merge 2 commits into
mainfrom
tmp-nx-draftfix-probe

Conversation

@sidj-thr

@sidj-thr sidj-thr commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Reusing this closed PR rather than opening a new one.

Head carries fix/ts-checks-nx-consolidate plus two probe-only commits: the eight legacy on-pr--ts.yml are deleted so they cannot also produce the checks, and one marker file is added under packages/ocr-ggml so both on-pr-ts-nx and on-pr-nx fire on a packages/** change.

Expected: on-pr-ts-nx's matrix job computes the affected ts packages, only those static jobs run, and every check name on-pr-nx polls for appears and resolves in seconds rather than timing out at 25 minutes.

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

License compliance — findings detected (warn-only)

Critical: 0 · High: 2 · Medium: 0

Dependency License Scope Severity Outcome
actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd (none detected) runtime High blocks
actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f (none detected) runtime High blocks

How to resolve a blocking finding:

  • Remove or replace the disallowed dependency, or
  • If the license is genuinely acceptable, run the compliance SKILL and record the decision in .github/license-allowlist.yml (CODEOWNERS-reviewed), or
  • For a one-off, a maintainer can apply the license-override label (High findings only; Critical cannot be overridden).

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./docs/website
  • ./packages/fabric/test/integration
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/inference-addon-cpp/mobile
  • ./packages/asr-ggml/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/sdk/e2e
  • ./packages/vla-ggml/sim/server
  • ./.github/actions/release-merge-guard

@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

Workflow security (shadow mode)

zizmor found 1108 finding(s) in .github/ (highest severity: high). This check is warn-only and does not block the merge.

Findings are annotated inline on the changed files and listed in the job summary.

Reproduce locally:

pipx run zizmor==1.27.0 --offline .github/

@sidj-thr

Copy link
Copy Markdown
Contributor Author

Probe complete. Run 35060717782 (event=pull_request, so the definition came from this head) went green with publish-prebuild-status skipped instead of erroring. Closing; branch deleted. Tip was 1fe6043 if it needs restoring.

@sidj-thr

Copy link
Copy Markdown
Contributor Author

Probe complete, both fixes verified. 1fe6043 (empty-matrix fix only) greened merge-guard with nothing verified; 3b3fc3a (both fixes) fails it with all four errors. Branch deleted.

@sidj-thr sidj-thr closed this Sep 16, 2026
@sidj-thr sidj-thr reopened this Sep 16, 2026
@sidj-thr
sidj-thr marked this pull request as ready for review September 16, 2026 08:54
@sidj-thr
sidj-thr requested review from a team as code owners September 16, 2026 08:54
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@sidj-thr
sidj-thr force-pushed the tmp-nx-draftfix-probe branch from 3b3fc3a to cb175f2 Compare September 16, 2026 08:54
@sidj-thr sidj-thr changed the title DO NOT MERGE: probe the publish-prebuild-status draft fix DO NOT MERGE: probe nx affected selection via the API path list Sep 16, 2026
@sidj-thr sidj-thr reopened this Sep 16, 2026
@sidj-thr
sidj-thr force-pushed the tmp-nx-draftfix-probe branch from cb175f2 to b2a3ff6 Compare September 16, 2026 13:53
@sidj-thr sidj-thr changed the title DO NOT MERGE: probe nx affected selection via the API path list DO NOT MERGE: probe the consolidated on-pr-ts-nx producer Sep 16, 2026
@sidj-thr

Copy link
Copy Markdown
Contributor Author

Probe complete, folded into #4497. on-pr-ts-nx selected ["ocr-ggml"], ran that job only, skipped the other seven, and the await resolved. Branch deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant