Conversation
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Contributor
Author
|
Probe complete. Run 35097979351 went green with the 14-package fan-out and all six awaits resolving in 5-11s; five of them reachable only through the nx.json path added in #4497. Branches deleted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolation check for #4497.
Base is tmp-ts-paths-base, which already carries the eight-file paths change, so this PR's own diff is exactly one file: nx.json. No .github/workflows/-ts.yml file is touched, which means the existing '.github/workflows/*.yml' glob in each producer cannot be the reason any of them fire.
Expected: nx marks all 14 packages affected on an nx.json change, on-pr-nx awaits six ts-checks, the producers fire via the newly added 'nx.json' path, and every await resolves in seconds instead of timing out at 25 minutes.
If the awaits time out, the fix does not work.