Skip to content

DO NOT MERGE: prove the new ts-checks paths fire on an nx global input - #4498

Closed
sidj-thr wants to merge 2 commits into
tmp-ts-paths-basefrom
tmp-ts-paths-probe
Closed

sidj-thr wants to merge 2 commits into
tmp-ts-paths-basefrom
tmp-ts-paths-probe

Conversation

@sidj-thr

Copy link
Copy Markdown
Contributor

Isolation check for #4497.

Base is tmp-ts-paths-base, which already carries the eight-file paths change, so this PR's own diff is exactly one file: nx.json. No .github/workflows/-ts.yml file is touched, which means the existing '.github/workflows/*.yml' glob in each producer cannot be the reason any of them fire.

Expected: nx marks all 14 packages affected on an nx.json change, on-pr-nx awaits six ts-checks, the producers fire via the newly added 'nx.json' path, and every await resolves in seconds instead of timing out at 25 minutes.

If the awaits time out, the fix does not work.

@sidj-thr
sidj-thr requested review from a team as code owners September 16, 2026 12:40
@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./docs/website
  • ./packages/fabric/test/integration
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/inference-addon-cpp/mobile
  • ./packages/asr-ggml/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/sdk/e2e
  • ./packages/vla-ggml/sim/server
  • ./.github/actions/release-merge-guard

@sidj-thr

Copy link
Copy Markdown
Contributor Author

Probe complete. Run 35097979351 went green with the 14-package fan-out and all six awaits resolving in 5-11s; five of them reachable only through the nx.json path added in #4497. Branches deleted.

@sidj-thr sidj-thr closed this Sep 16, 2026
@sidj-thr
sidj-thr deleted the tmp-ts-paths-probe branch September 16, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant