Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Contributor
Workflow security (shadow mode)zizmor found 1125 finding(s) in Findings are annotated inline on the changed files and listed in the job summary. Reproduce locally: pipx run zizmor==1.27.0 --offline .github/ |
translation-nmtcpp's on-merge workflow used to pass tag_name: v<version> to the reusable tag workflow, so its releases claimed 23 bare v<version> tags in the repo-wide namespace (v0.7.0..v0.13.1 and v6.1.0..v10.0.0). #4326 switched that caller to repo_name, but the override input stayed behind, and v0.13.1 (2026-09-13) still got a bare tag because its release branch was cut before that fix. Remove the tag_name input and the override branch in the shell step, make repo_name required, and keep the empty-prefix guard since required: true accepts an explicit "". Every caller already passes repo_name; a caller that reintroduces tag_name now fails workflow validation instead of silently creating a repo-wide tag. The historical bare tags keep their names.
RamazTs
force-pushed
the
fix/QVAC-24632-translation-nmtcpp-release-tag
branch
from
September 17, 2026 16:02
2c0a8c5 to
87b5306
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
@qvac/translation-nmtcppreleases claimed barev<version>tags in the repo-wide namespace (23 of them:v0.7.0–v0.13.1andv6.1.0–v10.0.0), sohttps://github.com/tetherto/qvac/releases/tag/v0.13.0reads as a monorepo release. Every other package tags as<package>-v<version>.repo_name, but thetag_nameoverride input that made a bare tag possible stayed increate-release-tag.yml.v0.13.1(2026-09-13) still landed as a bare tag because its release branch was cut before infra[notask]: prefix translation-nmtcpp release tags with the package name #4326.📝 How does it solve it?
create-release-tag.yml: remove thetag_nameinput and the override branch in the shell step;repo_namebecomes required. The empty-prefix guard stays becauserequired: trueaccepts an explicit"", and an empty prefix would produce the bare-v<version>shape this workflow exists to prevent.repo_nameand none passtag_name. A caller that reintroduces it is flagged by actionlint (input "tag_name" is not defined) and rejected by GitHub's workflow validation at run time, instead of silently creating a repo-wide tag.on-merge-translation-nmtcpp.yml: comment only.v*tags.release-translation-nmtcpp-*branches cut before infra[notask]: prefix translation-nmtcpp release tags with the package name #4326 still carry the old caller and callee, so a hotfix released from one of them would tag bare again unless infra[notask]: prefix translation-nmtcpp release tags with the package name #4326 and this change are cherry-picked first.🧪 How was it tested?
actionlint -oneline -shellcheck= -pyflakes=on both files plusnode .github/scripts/lint-workflows.mjs --input …(the CI gate): output identical tomain, only the pre-existing empty-choice-option finding on the dispatch input.actionlint(with shellcheck) oncreate-release-tag.yml: clean.tag_nameproducedinput "tag_name" is not defined in "./.github/workflows/create-release-tag.yml"andinput "repo_name" is required.package.jsonchanges; no version bump is warranted (workflow-only change).