Skip to content

QVAC-24632 infra: drop the tag_name override from create-release-tag.yml - #4561

Open
RamazTs wants to merge 1 commit into
mainfrom
fix/QVAC-24632-translation-nmtcpp-release-tag
Open

RamazTs wants to merge 1 commit into
mainfrom
fix/QVAC-24632-translation-nmtcpp-release-tag

Conversation

@RamazTs

@RamazTs RamazTs commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

📝 How does it solve it?

  • create-release-tag.yml: remove the tag_name input and the override branch in the shell step; repo_name becomes required. The empty-prefix guard stays because required: true accepts an explicit "", and an empty prefix would produce the bare -v<version> shape this workflow exists to prevent.
  • All 31 callers already pass repo_name and none pass tag_name. A caller that reintroduces it is flagged by actionlint (input "tag_name" is not defined) and rejected by GitHub's workflow validation at run time, instead of silently creating a repo-wide tag.
  • on-merge-translation-nmtcpp.yml: comment only.
  • The 23 historical bare tags are left as they are; no GitHub Release object is attached to any of them, and nothing in the repo consumes bare v* tags.
  • Caveat: release-translation-nmtcpp-* branches cut before infra[notask]: prefix translation-nmtcpp release tags with the package name #4326 still carry the old caller and callee, so a hotfix released from one of them would tag bare again unless infra[notask]: prefix translation-nmtcpp release tags with the package name #4326 and this change are cherry-picked first.

🧪 How was it tested?

  • actionlint -oneline -shellcheck= -pyflakes= on both files plus node .github/scripts/lint-workflows.mjs --input … (the CI gate): output identical to main, only the pre-existing empty-choice-option finding on the dispatch input.
  • Full actionlint (with shellcheck) on create-release-tag.yml: clean.
  • Negative probe: a temporary caller passing tag_name produced input "tag_name" is not defined in "./.github/workflows/create-release-tag.yml" and input "repo_name" is required.
  • No package.json changes; no version bump is warranted (workflow-only change).

@RamazTs
RamazTs requested review from a team as code owners September 17, 2026 16:00
@github-actions

Copy link
Copy Markdown
Contributor

Review Status

Current Status: ❌ PENDING
Approvals so far: none

Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member.

@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./docs/website
  • ./packages/fabric/test/integration
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/inference-addon-cpp/mobile
  • ./packages/asr-ggml/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/sdk/e2e
  • ./packages/vla-ggml/sim/server
  • ./.github/actions/release-merge-guard

@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Workflow security (shadow mode)

zizmor found 1125 finding(s) in .github/ (highest severity: high). This check is warn-only and does not block the merge.

Findings are annotated inline on the changed files and listed in the job summary.

Reproduce locally:

pipx run zizmor==1.27.0 --offline .github/

translation-nmtcpp's on-merge workflow used to pass tag_name: v<version>
to the reusable tag workflow, so its releases claimed 23 bare v<version>
tags in the repo-wide namespace (v0.7.0..v0.13.1 and v6.1.0..v10.0.0).
#4326 switched that caller to repo_name, but the override input stayed
behind, and v0.13.1 (2026-09-13) still got a bare tag because its release
branch was cut before that fix.

Remove the tag_name input and the override branch in the shell step, make
repo_name required, and keep the empty-prefix guard since required: true
accepts an explicit "". Every caller already passes repo_name; a caller
that reintroduces tag_name now fails workflow validation instead of
silently creating a repo-wide tag.

The historical bare tags keep their names.
@RamazTs
RamazTs force-pushed the fix/QVAC-24632-translation-nmtcpp-release-tag branch from 2c0a8c5 to 87b5306 Compare September 17, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant