chore[notask]: document changelog lockstep base and holepunch prettier - #4569
Open
opaninakuffo wants to merge 6 commits into
Open
opaninakuffo wants to merge 6 commits into
opaninakuffo wants to merge 6 commits into
Conversation
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
Victor-Rodzko
previously approved these changes
Sep 18, 2026
git log is the generate range, not the consumer delta. Catch missed exports, routes, catalog removals, and NOTICE JS wipes on every package.
…edure Lockstep always passes --base-commit; cascade follows the skill instead of the generator shortcut; release heads stay chore/*-changelog.
Plugins are not under packages/<slug>. bun install is not safe while a lockstep dep is unpublished.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
Changelog generate is
git log <base>..HEAD. That range is not the consumer delta, so notes can miss exports, routes, and catalog removals that are already in the tree vs the last published tag. A failed NOTICEnpm installcan also wipe the JS section.📝 How does it solve it?
sdk+inferenceshare one display floor; when that floor is a patch, union the main-only window. SDK is the consumer set; inference is the engine slice.<slug>-v*tag and hand-adds gaps.models.mdis the full list; catalog-as-API removals go inbreaking.md.chore:(no[bc]); body API / Models / Breaking are copied fromchangelog/<this version>/.GIT_DIRand org-remote push stay in footguns.🧪 How was it tested?