Conversation
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway CI probe for #4555. Not for review, not for merge. Will be closed once the runs are read.
The base branch
tmp-nx-ci-fixescarries #4555's four commits.on-pr-nx.ymland the workflows it calls withuses: ./resolve from the base, so this is the only way to exercise those fixes before #4555 lands.The diff is two README comment lines, chosen to make nx select
vla-ggmlandembed-llamacppand nothing else.What the runs should show:
vla-pr-head-ts-checks / ts-checksexecutes instead of skipping, andAwait PR-head TypeScript checksin the VLA run completes in seconds rather than timing out at 25 minutes. Todayvla-ggmlis stripped from the matrix as a carve-out before the TS producer reads it.cpp-lintrows receive the fabric overlay only when the package is in.github/fabric-consumers.json.prebuilds-embed-llamacpprather than the bareprebuildsname it publishes under.