Skip to content

QVAC-19792 test[notask]: CI probe for #4555, do not merge - #4573

Closed
sidj-thr wants to merge 1 commit into
tmp-nx-ci-fixesfrom
probe/nx-ci-fixes
Closed

sidj-thr wants to merge 1 commit into
tmp-nx-ci-fixesfrom
probe/nx-ci-fixes

Conversation

@sidj-thr

Copy link
Copy Markdown
Contributor

Throwaway CI probe for #4555. Not for review, not for merge. Will be closed once the runs are read.

The base branch tmp-nx-ci-fixes carries #4555's four commits. on-pr-nx.yml and the workflows it calls with uses: ./ resolve from the base, so this is the only way to exercise those fixes before #4555 lands.

The diff is two README comment lines, chosen to make nx select vla-ggml and embed-llamacpp and nothing else.

What the runs should show:

  • vla-pr-head-ts-checks / ts-checks executes instead of skipping, and Await PR-head TypeScript checks in the VLA run completes in seconds rather than timing out at 25 minutes. Today vla-ggml is stripped from the matrix as a carve-out before the TS producer reads it.
  • cpp-lint rows receive the fabric overlay only when the package is in .github/fabric-consumers.json.
  • The Embed integration lane downloads prebuilds-embed-llamacpp rather than the bare prebuilds name it publishes under.

@sidj-thr
sidj-thr requested review from a team as code owners September 18, 2026 08:33
@sidj-thr sidj-thr added the run-desktop-addon-tests CI: run desktop integration tests (requires verified) label Sep 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

License compliance — clean

No new dependency license findings in this PR.

Warn-only (shadow) mode — this check does not block merges yet.

Updated automatically by the canonical license compliance workflow.

NOTICE presence (advisory)

Missing NOTICE (advisory, does not block):

  • ./docs/website
  • ./packages/fabric/test/integration
  • ./packages/llm-llamacpp/benchmarks/server
  • ./packages/llm-llamacpp/benchmarks/performance
  • ./packages/inference-addon-cpp/mobile
  • ./packages/asr-ggml/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/server
  • ./packages/embed-llamacpp/benchmarks/performance
  • ./packages/sdk/e2e
  • ./packages/vla-ggml/sim/server
  • ./.github/actions/release-merge-guard

@sidj-thr sidj-thr closed this Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-desktop-addon-tests CI: run desktop integration tests (requires verified)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant