Conversation
…qvac-fabric 10549.2.0 DO NOT MERGE. Rollout Phase A validation branch for qvac-fabric 10549.2.0. Adds the shared qvac-fabric overlay port pinned at b1758d07c3e957f5ed032f4701fa729b8b18b1df and points the 2 derived vcpkg fabric consumers at it, so they build against the fabric commit before the v10549.2.0 tag exists and before anything is published to the registry. Derived roster from origin/main with: git grep -l qvac-fabric origin/main -- packages/*/vcpkg.json. Consumers: fabric, llm-llamacpp. Consumer version>= pins are untouched; the overlay bypasses version resolution entirely, so only the overlay port's own version matters here. default-registry.baseline is untouched in both consumers. Rollout-Overlay: qvac-fabric 10549.2.0 ref=b1758d07c3e957f5ed032f4701fa729b8b18b1df sha=b1758d07c3e957f5ed032f4701fa729b8b18b1df
Contributor
Review StatusCurrent Status: ❌ PENDING Pending reviews: Needs 1 Management or Team Lead, and 1 more from Management, Team Lead, or Member. |
dev-nid
added
run-cpp-addon-tests
Contributor
License compliance — cleanNo new dependency license findings in this PR. Warn-only (shadow) mode — this check does not block merges yet. Updated automatically by the canonical license compliance workflow. NOTICE presence (advisory)Missing NOTICE (advisory, does not block):
|
dev-nid
added
the
run-coload-tests
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
3 similar comments
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
Contributor
🧪 C++ Test Coverage ReportCoverage: 📊 Detailed Coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This branch is Rollout Phase A scaffolding for qvac-fabric 10549.2.0. It exists only so the current vcpkg fabric consumers compile against the new fabric commit before the
v10549.2.0tag is cut and before anything is published toqvac-registry-vcpkg./rollout-phase-bcloses this validation PR unmerged once Phase A is green and the registry PR lands. The consumerversion>=bumps ride Phase B's bundled PR, not this one.Problem
temp-10549has advanced pastv10549.1.0, and the remaining vcpkg fabric consumers need to validate against the new fabric commit before it becomes the released registry version.How
Adds
vcpkg-overlays/ports/qvac-fabric/and points the derived vcpkg fabric consumers at it viaoverlay-ports. An overlay port bypasses vcpkg's version resolution entirely, so these consumers build the pinned commit regardless of what the registry currently publishes.What is being validated
temp-10549b1758d07c3e957f5ed032f4701fa729b8b18b1dfv10549.2.0Consumers -- derived, not hardcoded
Derived with:
Current vcpkg fabric consumers:
fabricllm-llamacppMigrated npm-runtime consumers are deliberately not overlaid here. They consume the published
@qvac/fabricpath and are exercised through thefabric-prebuildsartifact from the Fabric run, not by addingoverlay-ports.Untouched, deliberately
version>=pins are unchanged.default-registry.baselineis unchanged.version>=bump.Tested
vcpkg-overlays/ports/qvac-fabric/{portfile.cmake,vcpkg.json}git diff --checkpasseddefault-registry.baselineor consumerversion>=changesREFis pinned to the commit SHA, not the movingtemp-10549branch/archive/<commit>.tar.gzarchive vcpkg fetchesNotes for reviewers
Building qvac-fabric.